From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:56901) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SCWvb-0004EN-8V for qemu-devel@nongnu.org; Tue, 27 Mar 2012 09:59:16 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1SCWvW-0002wO-JL for qemu-devel@nongnu.org; Tue, 27 Mar 2012 09:59:14 -0400 Received: from mx1.redhat.com ([209.132.183.28]:16629) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SCWvW-0002vw-BN for qemu-devel@nongnu.org; Tue, 27 Mar 2012 09:59:10 -0400 Message-ID: <4F71C79F.8000505@redhat.com> Date: Tue, 27 Mar 2012 15:58:55 +0200 From: Paolo Bonzini MIME-Version: 1.0 References: <1332740423-8426-1-git-send-email-zwu.kernel@gmail.com> <1332740423-8426-2-git-send-email-zwu.kernel@gmail.com> <4F71791C.1060601@redhat.com> <4F719328.8010409@redhat.com> In-Reply-To: Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [RFC 1/9] hostdev: introduce the infrastructure for host device model List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Zhi Yong Wu Cc: Zhi Yong Wu , qemu-devel@nongnu.org, stefanha@linux.vnet.ibm.com Il 27/03/2012 13:59, Zhi Yong Wu ha scritto: > On Tue, Mar 27, 2012 at 6:15 PM, Paolo Bonzini wrote: >> Il 27/03/2012 11:06, Zhi Yong Wu ha scritto: >>>>>>> +#define DEFINE_HOSTDEV_PROP_PEER(_n, _s, _f) \ >>>>>>> + DEFINE_HOSTDEV_PROP(_n, _s, _f, hostdev_prop_netdev, NetClientState*) >>>>> >>>>> This should be simply a link property. >>> IMHO, i don't fully understand what link mean. What is the >>> difference between it and Child. Can you elaborate this? >> >> link is a pointer to another object. child means that > Where are link used? The peer property needs to be one. > what is relationship between the two objects? A has a pointer to B. > it represent the relation between bus object and device object? We're talking about netdevs, bus and object does not matter here no? > We will not convert -net to QOM, that is, we don't care -net nic. As long as it works that's fine but... > Moreover, -device has exposed network card info. ... this is extremely confused. Each NIC device has a NIC-type NetClientState. If NetClientState is converted to QOM, all of its instances should be QOM objects, including those owned by NICs. >> 3) the network devices already support hotplug very well, so it's also >> not too useful to do them first. Let's first do chardevs. > > We hope that -netdev options info can be configurated or changed > purely via QOM, not command line. Yes, but does it buy anything or it is just a nice exercise? Paolo