* [Qemu-devel] [PATCH] configure: fix mingw32 libs_qga typo
@ 2012-03-27 7:26 Stefan Hajnoczi
2012-03-27 14:19 ` Andreas Färber
2012-03-27 14:49 ` Stefan Hajnoczi
0 siblings, 2 replies; 3+ messages in thread
From: Stefan Hajnoczi @ 2012-03-27 7:26 UTC (permalink / raw)
To: qemu-devel; +Cc: Lee Essen, Stefan Hajnoczi
It's typical to prepend or append parameters to an argument string so
that other places in ./configure can add parameters without clobbering
the string. In the mingw32 libs_qga case there is a typo "$lib_qga"
instead of "$libs_qga".
Signed-off-by: Stefan Hajnoczi <stefanha@linux.vnet.ibm.com>
---
configure | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/configure b/configure
index 14ef738..d63c011 100755
--- a/configure
+++ b/configure
@@ -526,7 +526,7 @@ EOF
bindir="\${prefix}"
sysconfdir="\${prefix}"
confsuffix=""
- libs_qga="-lws2_32 -lwinmm -lpowrprof $lib_qga"
+ libs_qga="-lws2_32 -lwinmm -lpowrprof $libs_qga"
fi
werror=""
--
1.7.9.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [Qemu-devel] [PATCH] configure: fix mingw32 libs_qga typo
2012-03-27 7:26 [Qemu-devel] [PATCH] configure: fix mingw32 libs_qga typo Stefan Hajnoczi
@ 2012-03-27 14:19 ` Andreas Färber
2012-03-27 14:49 ` Stefan Hajnoczi
1 sibling, 0 replies; 3+ messages in thread
From: Andreas Färber @ 2012-03-27 14:19 UTC (permalink / raw)
To: Stefan Hajnoczi; +Cc: Lee Essen, Stefan Weil, qemu-devel
Am 27.03.2012 09:26, schrieb Stefan Hajnoczi:
> It's typical to prepend or append parameters to an argument string so
> that other places in ./configure can add parameters without clobbering
> the string. In the mingw32 libs_qga case there is a typo "$lib_qga"
> instead of "$libs_qga".
>
> Signed-off-by: Stefan Hajnoczi <stefanha@linux.vnet.ibm.com>
Reviewed-by: Andreas Färber <afaerber@suse.de>
Andreas
> ---
> configure | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/configure b/configure
> index 14ef738..d63c011 100755
> --- a/configure
> +++ b/configure
> @@ -526,7 +526,7 @@ EOF
> bindir="\${prefix}"
> sysconfdir="\${prefix}"
> confsuffix=""
> - libs_qga="-lws2_32 -lwinmm -lpowrprof $lib_qga"
> + libs_qga="-lws2_32 -lwinmm -lpowrprof $libs_qga"
> fi
>
> werror=""
--
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 16746 AG Nürnberg
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [Qemu-devel] [PATCH] configure: fix mingw32 libs_qga typo
2012-03-27 7:26 [Qemu-devel] [PATCH] configure: fix mingw32 libs_qga typo Stefan Hajnoczi
2012-03-27 14:19 ` Andreas Färber
@ 2012-03-27 14:49 ` Stefan Hajnoczi
1 sibling, 0 replies; 3+ messages in thread
From: Stefan Hajnoczi @ 2012-03-27 14:49 UTC (permalink / raw)
To: Stefan Hajnoczi; +Cc: Lee Essen, qemu-devel
On Tue, Mar 27, 2012 at 08:26:18AM +0100, Stefan Hajnoczi wrote:
> It's typical to prepend or append parameters to an argument string so
> that other places in ./configure can add parameters without clobbering
> the string. In the mingw32 libs_qga case there is a typo "$lib_qga"
> instead of "$libs_qga".
>
> Signed-off-by: Stefan Hajnoczi <stefanha@linux.vnet.ibm.com>
> ---
> configure | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
Applied to the trivial patches tree:
https://github.com/stefanha/qemu/commits/trivial-patches
Stefan
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2012-03-27 14:50 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-03-27 7:26 [Qemu-devel] [PATCH] configure: fix mingw32 libs_qga typo Stefan Hajnoczi
2012-03-27 14:19 ` Andreas Färber
2012-03-27 14:49 ` Stefan Hajnoczi
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).