From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([208.118.235.92]:57761)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <paolo.bonzini@gmail.com>) id 1SCXtl-0003g0-Bh
	for qemu-devel@nongnu.org; Tue, 27 Mar 2012 11:01:34 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <paolo.bonzini@gmail.com>) id 1SCXtb-0007XM-3b
	for qemu-devel@nongnu.org; Tue, 27 Mar 2012 11:01:24 -0400
Received: from mail-gx0-f173.google.com ([209.85.161.173]:49399)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <paolo.bonzini@gmail.com>) id 1SCXta-0007XA-U5
	for qemu-devel@nongnu.org; Tue, 27 Mar 2012 11:01:15 -0400
Received: by ggnp2 with SMTP id p2so1496440ggn.4
	for <qemu-devel@nongnu.org>; Tue, 27 Mar 2012 08:01:13 -0700 (PDT)
Sender: Paolo Bonzini <paolo.bonzini@gmail.com>
Message-ID: <4F71D631.5000007@redhat.com>
Date: Tue, 27 Mar 2012 17:01:05 +0200
From: Paolo Bonzini <pbonzini@redhat.com>
MIME-Version: 1.0
References: <1332606390-3605-1-git-send-email-lee.essen@nowonline.co.uk>
	<1332606390-3605-3-git-send-email-lee.essen@nowonline.co.uk>
In-Reply-To: <1332606390-3605-3-git-send-email-lee.essen@nowonline.co.uk>
Content-Type: text/plain; charset=ISO-8859-15
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH 3/4] Enable qemu-timer dynticks for Solaris
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Lee Essen <lee.essen@nowonline.co.uk>
Cc: Blue Swirl <blauwirbel@gmail.com>, Jan Kiszka <jan.kiszka@siemens.com>, =?ISO-8859-15?Q?Andreas_F=E4rber?= <andreas.faerber@web.de>, qemu-devel@nongnu.org

Il 24/03/2012 17:26, Lee Essen ha scritto:
> Dynticks was limited to linux. This patch adds Solaris support
> and ensures a CLOCK_HIGHRES clock is used which is the optimal
> setup for Solaris systems.

Looks good, but I would prefer if you tested for timer_create in
configure and use #ifdef CONFIG_RT_TIMER instead.

> +#if defined(__sun__)
> +    if (timer_create(CLOCK_HIGHRES, &ev, &host_timer)) {
> +#else
>      if (timer_create(CLOCK_REALTIME, &ev, &host_timer)) {
> +#endif

This should be #ifdef CLOCK_HIGHRES.

Paolo