From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([208.118.235.92]:57728)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <meador_inge@mentor.com>) id 1SCXzm-0000vt-Q7
	for qemu-devel@nongnu.org; Tue, 27 Mar 2012 11:07:43 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <meador_inge@mentor.com>) id 1SCXzg-000171-G6
	for qemu-devel@nongnu.org; Tue, 27 Mar 2012 11:07:38 -0400
Received: from relay1.mentorg.com ([192.94.38.131]:35262)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <meador_inge@mentor.com>) id 1SCXzg-000160-9B
	for qemu-devel@nongnu.org; Tue, 27 Mar 2012 11:07:32 -0400
Message-ID: <4F71D7AD.8080103@codesourcery.com>
Date: Tue, 27 Mar 2012 10:07:25 -0500
From: Meador Inge <meadori@codesourcery.com>
MIME-Version: 1.0
References: <1330121921-23462-1-git-send-email-meadori@codesourcery.com>
	<4F4814F7.6040008@suse.de>
In-Reply-To: <4F4814F7.6040008@suse.de>
Content-Type: text/plain; charset="ISO-8859-15"
Content-Transfer-Encoding: 8bit
Subject: Re: [Qemu-devel] [PATCH v1 1/1] m68k: Return semihosting errno
 values correctly
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: qemu-devel@nongnu.org
Cc: =?ISO-8859-15?Q?Andreas_F=E4rber?= <afaerber@suse.de>, paul@codesourcery.com

Ping.

On 02/24/2012 04:53 PM, Andreas Färber wrote:
> Am 24.02.2012 23:18, schrieb Meador Inge:
>> Fixing a simple typo, s/errno/err/, that caused
>> the error status from GDB semihosted system calls
>> to be returned incorrectly.
>>
>> Signed-off-by: Meador Inge <meadori@codesourcery.com>
> 
> Nice catch!
> 
> Reviewed-by: Andreas Färber <afaerber@suse.de>
> 
> Andreas
> 
>> ---
>>  m68k-semi.c |    2 +-
>>  1 files changed, 1 insertions(+), 1 deletions(-)
>>
>> diff --git a/m68k-semi.c b/m68k-semi.c
>> index bab01ee..6d60ced 100644
>> --- a/m68k-semi.c
>> +++ b/m68k-semi.c
>> @@ -150,7 +150,7 @@ static void m68k_semi_cb(CPUState *env, target_ulong ret, target_ulong err)
>>      }
>>      /* FIXME - handle put_user() failure */
>>      put_user_u32(ret, args);
>> -    put_user_u32(errno, args + 4);
>> +    put_user_u32(err, args + 4);
>>  }
>>  
>>  #define ARG(n)					\
> 


-- 
Meador Inge
CodeSourcery / Mentor Embedded
http://www.mentor.com/embedded-software