From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([208.118.235.92]:57885)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <jan.kiszka@siemens.com>) id 1SCY0T-0001xm-Vb
	for qemu-devel@nongnu.org; Tue, 27 Mar 2012 11:08:23 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <jan.kiszka@siemens.com>) id 1SCY0L-0001QE-Lo
	for qemu-devel@nongnu.org; Tue, 27 Mar 2012 11:08:21 -0400
Received: from david.siemens.de ([192.35.17.14]:33162)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <jan.kiszka@siemens.com>) id 1SCY0L-0001Po-Bt
	for qemu-devel@nongnu.org; Tue, 27 Mar 2012 11:08:13 -0400
Message-ID: <4F71D7D9.1040501@siemens.com>
Date: Tue, 27 Mar 2012 17:08:09 +0200
From: Jan Kiszka <jan.kiszka@siemens.com>
MIME-Version: 1.0
References: <1332606390-3605-1-git-send-email-lee.essen@nowonline.co.uk>
	<1332606390-3605-3-git-send-email-lee.essen@nowonline.co.uk>
	<4F71D631.5000007@redhat.com>
In-Reply-To: <4F71D631.5000007@redhat.com>
Content-Type: text/plain; charset=ISO-8859-15
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH 3/4] Enable qemu-timer dynticks for Solaris
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Paolo Bonzini <pbonzini@redhat.com>
Cc: Lee Essen <lee.essen@nowonline.co.uk>, Blue Swirl <blauwirbel@gmail.com>, =?ISO-8859-15?Q?Andreas_F=E4rber?= <andreas.faerber@web.de>, "qemu-devel@nongnu.org" <qemu-devel@nongnu.org>

On 2012-03-27 17:01, Paolo Bonzini wrote:
> Il 24/03/2012 17:26, Lee Essen ha scritto:
>> Dynticks was limited to linux. This patch adds Solaris support
>> and ensures a CLOCK_HIGHRES clock is used which is the optimal
>> setup for Solaris systems.
> 
> Looks good, but I would prefer if you tested for timer_create in
> configure and use #ifdef CONFIG_RT_TIMER instead.
> 
>> +#if defined(__sun__)
>> +    if (timer_create(CLOCK_HIGHRES, &ev, &host_timer)) {
>> +#else
>>      if (timer_create(CLOCK_REALTIME, &ev, &host_timer)) {
>> +#endif
> 
> This should be #ifdef CLOCK_HIGHRES.

Are we sure about this is and will remain equivalent and correct?

Also, I found some man page that says CLOCK_HIGHRES is non-adjustable
while CLOCK_REALTIME is. That should make a difference in QEMU.

Jan

-- 
Siemens AG, Corporate Technology, CT T DE IT 1
Corporate Competence Center Embedded Linux