From: "Andreas Färber" <afaerber@suse.de>
To: Kevin Wolf <kwolf@redhat.com>
Cc: aliguori@us.ibm.com, mst@redhat.com,
Alexander Graf <agraf@suse.de>,
qemu-devel@nongnu.org, qemu-ppc <qemu-ppc@nongnu.org>,
David Gibson <david@gibson.dropbear.id.au>
Subject: Re: [Qemu-devel] [PATCH] Use DMADirection type for dma_bdrv_io
Date: Tue, 27 Mar 2012 17:17:23 +0200 [thread overview]
Message-ID: <4F71DA03.7050500@suse.de> (raw)
In-Reply-To: <4F71D20D.4090505@redhat.com>
Am 27.03.2012 16:43, schrieb Kevin Wolf:
> Am 27.03.2012 16:30, schrieb Andreas Färber:
>> Am 27.03.2012 04:42, schrieb David Gibson:
>>> Currently dma_bdrv_io() takes a 'to_dev' boolean parameter to
>>> determine the direction of DMA it is emulating. We already have a
>>> DMADirection enum designed specifically to encode DMA directions.
>>> This patch uses it for dma_bdrv_io() as well. This involves removing
>>> the DMADirection definition from the #ifdef it was inside, but since that
>>> only existed to protect the definition of dma_addr_t from places where
>>> config.h is not included, there wasn't any reason for it to be there in
>>> the first place.
>>>
>>> Cc: Kevin Wolf <kwolf@redhat.com>
>>>
>>> Signed-off-by: David Gibson <david@gibson.dropbear.id.au>
>>
>> Including for ppc macio in absence of Alex,
>>
>> Reviewed-by: Andreas Färber <afaerber@suse.de>
>>
>> (Expecting this to go through IDE/Kevin's tree.)
>
> So this isn't part of another series any more?
AFAICS it's a single patch on qemu-devel, split out of one of the
"Various fixes David has piled up" series on Alex' suggestion.
Andreas
--
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 16746 AG Nürnberg
next prev parent reply other threads:[~2012-03-27 15:17 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-03-27 2:42 [Qemu-devel] [PATCH] Use DMADirection type for dma_bdrv_io David Gibson
2012-03-27 7:17 ` Stefan Hajnoczi
2012-03-27 14:30 ` Andreas Färber
2012-03-27 14:43 ` Kevin Wolf
2012-03-27 15:14 ` [Qemu-devel] [Qemu-ppc] " David Gibson
2012-03-27 15:17 ` Andreas Färber [this message]
2012-03-27 15:23 ` [Qemu-devel] " Kevin Wolf
2012-03-28 0:42 ` [Qemu-devel] [Qemu-ppc] " David Gibson
-- strict thread matches above, loose matches on Subject: below --
2012-02-20 3:01 [Qemu-devel] " David Gibson
2012-02-20 10:50 ` Alexander Graf
2012-02-21 1:14 ` David Gibson
2012-02-21 8:35 ` Paolo Bonzini
2012-02-21 9:09 ` Kevin Wolf
2012-02-22 1:11 ` David Gibson
2012-02-22 9:54 ` Andreas Färber
2012-02-22 9:55 ` Hannes Reinecke
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4F71DA03.7050500@suse.de \
--to=afaerber@suse.de \
--cc=agraf@suse.de \
--cc=aliguori@us.ibm.com \
--cc=david@gibson.dropbear.id.au \
--cc=kwolf@redhat.com \
--cc=mst@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-ppc@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).