From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:51802) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SCY9H-0006Jw-Ni for qemu-devel@nongnu.org; Tue, 27 Mar 2012 11:17:33 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1SCY9F-0003yg-QQ for qemu-devel@nongnu.org; Tue, 27 Mar 2012 11:17:27 -0400 Message-ID: <4F71DA03.7050500@suse.de> Date: Tue, 27 Mar 2012 17:17:23 +0200 From: =?ISO-8859-15?Q?Andreas_F=E4rber?= MIME-Version: 1.0 References: <1332816143-4989-1-git-send-email-david@gibson.dropbear.id.au> <4F71CEF4.1020306@suse.de> <4F71D20D.4090505@redhat.com> In-Reply-To: <4F71D20D.4090505@redhat.com> Content-Type: text/plain; charset=ISO-8859-15 Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH] Use DMADirection type for dma_bdrv_io List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Kevin Wolf Cc: aliguori@us.ibm.com, mst@redhat.com, Alexander Graf , qemu-devel@nongnu.org, qemu-ppc , David Gibson Am 27.03.2012 16:43, schrieb Kevin Wolf: > Am 27.03.2012 16:30, schrieb Andreas F=E4rber: >> Am 27.03.2012 04:42, schrieb David Gibson: >>> Currently dma_bdrv_io() takes a 'to_dev' boolean parameter to >>> determine the direction of DMA it is emulating. We already have a >>> DMADirection enum designed specifically to encode DMA directions. >>> This patch uses it for dma_bdrv_io() as well. This involves removing >>> the DMADirection definition from the #ifdef it was inside, but since = that >>> only existed to protect the definition of dma_addr_t from places wher= e >>> config.h is not included, there wasn't any reason for it to be there = in >>> the first place. >>> >>> Cc: Kevin Wolf >>> >>> Signed-off-by: David Gibson >> >> Including for ppc macio in absence of Alex, >> >> Reviewed-by: Andreas F=E4rber >> >> (Expecting this to go through IDE/Kevin's tree.) >=20 > So this isn't part of another series any more? AFAICS it's a single patch on qemu-devel, split out of one of the "Various fixes David has piled up" series on Alex' suggestion. Andreas --=20 SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 N=FCrnberg, Germany GF: Jeff Hawn, Jennifer Guild, Felix Imend=F6rffer; HRB 16746 AG N=FCrnbe= rg