From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:49315) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SCYPa-0005wD-4v for qemu-devel@nongnu.org; Tue, 27 Mar 2012 11:34:22 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1SCYPU-0000jP-RE for qemu-devel@nongnu.org; Tue, 27 Mar 2012 11:34:17 -0400 Received: from mail-gx0-f173.google.com ([209.85.161.173]:56873) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SCYPU-0000iw-KY for qemu-devel@nongnu.org; Tue, 27 Mar 2012 11:34:12 -0400 Received: by ggnp2 with SMTP id p2so36123ggn.4 for ; Tue, 27 Mar 2012 08:34:10 -0700 (PDT) Sender: Richard Henderson Message-ID: <4F71DDF0.2080409@twiddle.net> Date: Tue, 27 Mar 2012 08:34:08 -0700 From: Richard Henderson MIME-Version: 1.0 References: <1332840290-24553-1-git-send-email-proljc@gmail.com> <1332840290-24553-3-git-send-email-proljc@gmail.com> In-Reply-To: <1332840290-24553-3-git-send-email-proljc@gmail.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH V3 02/12] Use correct acc value to index cpu_HI/cpu_LO rather than using a fix number List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Jia Liu Cc: qemu-devel@nongnu.org, aurelien@aurel32.net On 03/27/12 02:24, Jia Liu wrote: > There are 4 accumulator registers (acc) used by MIPS ASE DSP instructions. > Each accumulator register is composed of by HIGH and LOW part. Use correct > acc value to index cpu_HI/cpu_LO rather than using a fix number (i.e. zero). > > Signed-off-by: Jia Liu > --- > target-mips/translate.c | 56 ++++++++++++++++++++++++++++------------------ > 1 files changed, 34 insertions(+), 22 deletions(-) Reviewed-by: Richard Henderson r~