* [Qemu-devel] [PATCH v1 1/1] m68k: Return semihosting errno values correctly
@ 2012-02-24 22:18 Meador Inge
2012-02-24 22:53 ` Andreas Färber
0 siblings, 1 reply; 7+ messages in thread
From: Meador Inge @ 2012-02-24 22:18 UTC (permalink / raw)
To: qemu-devel; +Cc: paul
Fixing a simple typo, s/errno/err/, that caused
the error status from GDB semihosted system calls
to be returned incorrectly.
Signed-off-by: Meador Inge <meadori@codesourcery.com>
---
m68k-semi.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/m68k-semi.c b/m68k-semi.c
index bab01ee..6d60ced 100644
--- a/m68k-semi.c
+++ b/m68k-semi.c
@@ -150,7 +150,7 @@ static void m68k_semi_cb(CPUState *env, target_ulong ret, target_ulong err)
}
/* FIXME - handle put_user() failure */
put_user_u32(ret, args);
- put_user_u32(errno, args + 4);
+ put_user_u32(err, args + 4);
}
#define ARG(n) \
--
1.7.7.6
^ permalink raw reply related [flat|nested] 7+ messages in thread* Re: [Qemu-devel] [PATCH v1 1/1] m68k: Return semihosting errno values correctly
2012-02-24 22:18 [Qemu-devel] [PATCH v1 1/1] m68k: Return semihosting errno values correctly Meador Inge
@ 2012-02-24 22:53 ` Andreas Färber
2012-03-27 15:07 ` Meador Inge
0 siblings, 1 reply; 7+ messages in thread
From: Andreas Färber @ 2012-02-24 22:53 UTC (permalink / raw)
To: Meador Inge; +Cc: qemu-devel, paul
Am 24.02.2012 23:18, schrieb Meador Inge:
> Fixing a simple typo, s/errno/err/, that caused
> the error status from GDB semihosted system calls
> to be returned incorrectly.
>
> Signed-off-by: Meador Inge <meadori@codesourcery.com>
Nice catch!
Reviewed-by: Andreas Färber <afaerber@suse.de>
Andreas
> ---
> m68k-semi.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/m68k-semi.c b/m68k-semi.c
> index bab01ee..6d60ced 100644
> --- a/m68k-semi.c
> +++ b/m68k-semi.c
> @@ -150,7 +150,7 @@ static void m68k_semi_cb(CPUState *env, target_ulong ret, target_ulong err)
> }
> /* FIXME - handle put_user() failure */
> put_user_u32(ret, args);
> - put_user_u32(errno, args + 4);
> + put_user_u32(err, args + 4);
> }
>
> #define ARG(n) \
--
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 16746 AG Nürnberg
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [Qemu-devel] [PATCH v1 1/1] m68k: Return semihosting errno values correctly
2012-02-24 22:53 ` Andreas Färber
@ 2012-03-27 15:07 ` Meador Inge
2012-03-27 15:43 ` Peter Maydell
0 siblings, 1 reply; 7+ messages in thread
From: Meador Inge @ 2012-03-27 15:07 UTC (permalink / raw)
To: qemu-devel; +Cc: Andreas Färber, paul
Ping.
On 02/24/2012 04:53 PM, Andreas Färber wrote:
> Am 24.02.2012 23:18, schrieb Meador Inge:
>> Fixing a simple typo, s/errno/err/, that caused
>> the error status from GDB semihosted system calls
>> to be returned incorrectly.
>>
>> Signed-off-by: Meador Inge <meadori@codesourcery.com>
>
> Nice catch!
>
> Reviewed-by: Andreas Färber <afaerber@suse.de>
>
> Andreas
>
>> ---
>> m68k-semi.c | 2 +-
>> 1 files changed, 1 insertions(+), 1 deletions(-)
>>
>> diff --git a/m68k-semi.c b/m68k-semi.c
>> index bab01ee..6d60ced 100644
>> --- a/m68k-semi.c
>> +++ b/m68k-semi.c
>> @@ -150,7 +150,7 @@ static void m68k_semi_cb(CPUState *env, target_ulong ret, target_ulong err)
>> }
>> /* FIXME - handle put_user() failure */
>> put_user_u32(ret, args);
>> - put_user_u32(errno, args + 4);
>> + put_user_u32(err, args + 4);
>> }
>>
>> #define ARG(n) \
>
--
Meador Inge
CodeSourcery / Mentor Embedded
http://www.mentor.com/embedded-software
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [Qemu-devel] [PATCH v1 1/1] m68k: Return semihosting errno values correctly
2012-03-27 15:07 ` Meador Inge
@ 2012-03-27 15:43 ` Peter Maydell
2012-03-27 15:51 ` Andreas Färber
2012-10-29 9:42 ` Peter Maydell
0 siblings, 2 replies; 7+ messages in thread
From: Peter Maydell @ 2012-03-27 15:43 UTC (permalink / raw)
To: Meador Inge; +Cc: QEMU Trivial, Paul Brook, qemu-devel, Andreas Färber
This patch is simple enough (and m68k unmaintained enough)
that it could reasonably go through qemu-trivial I think.
-- PMM
On 27 March 2012 16:07, Meador Inge <meadori@codesourcery.com> wrote:
> Ping.
>
> On 02/24/2012 04:53 PM, Andreas Färber wrote:
>> Am 24.02.2012 23:18, schrieb Meador Inge:
>>> Fixing a simple typo, s/errno/err/, that caused
>>> the error status from GDB semihosted system calls
>>> to be returned incorrectly.
>>>
>>> Signed-off-by: Meador Inge <meadori@codesourcery.com>
>>
>> Nice catch!
>>
>> Reviewed-by: Andreas Färber <afaerber@suse.de>
>>
>> Andreas
>>
>>> ---
>>> m68k-semi.c | 2 +-
>>> 1 files changed, 1 insertions(+), 1 deletions(-)
>>>
>>> diff --git a/m68k-semi.c b/m68k-semi.c
>>> index bab01ee..6d60ced 100644
>>> --- a/m68k-semi.c
>>> +++ b/m68k-semi.c
>>> @@ -150,7 +150,7 @@ static void m68k_semi_cb(CPUState *env, target_ulong ret, target_ulong err)
>>> }
>>> /* FIXME - handle put_user() failure */
>>> put_user_u32(ret, args);
>>> - put_user_u32(errno, args + 4);
>>> + put_user_u32(err, args + 4);
>>> }
>>>
>>> #define ARG(n) \
>>
>
>
> --
> Meador Inge
> CodeSourcery / Mentor Embedded
> http://www.mentor.com/embedded-software
>
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [Qemu-devel] [PATCH v1 1/1] m68k: Return semihosting errno values correctly
2012-03-27 15:43 ` Peter Maydell
@ 2012-03-27 15:51 ` Andreas Färber
2012-10-29 9:42 ` Peter Maydell
1 sibling, 0 replies; 7+ messages in thread
From: Andreas Färber @ 2012-03-27 15:51 UTC (permalink / raw)
To: Peter Maydell, Paul Brook
Cc: QEMU Trivial, Meador Inge, qemu-devel, Anthony Liguori
Am 27.03.2012 17:43, schrieb Peter Maydell:
> This patch is simple enough (and m68k unmaintained enough)
> that it could reasonably go through qemu-trivial I think.
This one's a Mentor-internal issue though - Paul, are you planning to
handle (your colleague's) m68k patches? Or should we downgrade m68k to
S: Orphan and handle them through some other to be defined way?
I'm asking because I have m68k QOM'ification in the queue and Anthony
has set out not to apply patches for which a submaintainer is defined.
Andreas
--
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 16746 AG Nürnberg
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [Qemu-devel] [PATCH v1 1/1] m68k: Return semihosting errno values correctly
2012-03-27 15:43 ` Peter Maydell
2012-03-27 15:51 ` Andreas Färber
@ 2012-10-29 9:42 ` Peter Maydell
2012-10-29 10:03 ` [Qemu-devel] [Qemu-trivial] " Stefan Hajnoczi
1 sibling, 1 reply; 7+ messages in thread
From: Peter Maydell @ 2012-10-29 9:42 UTC (permalink / raw)
To: Meador Inge; +Cc: QEMU Trivial, Paul Brook, qemu-devel, Andreas Färber
I just noticed this patch never got applied by anybody
(and alas it now needs a refresh because the file was renamed
in the interim.)
-- PMM
On 27 March 2012 16:43, Peter Maydell <peter.maydell@linaro.org> wrote:
> This patch is simple enough (and m68k unmaintained enough)
> that it could reasonably go through qemu-trivial I think.
>
> -- PMM
>
> On 27 March 2012 16:07, Meador Inge <meadori@codesourcery.com> wrote:
>> Ping.
>>
>> On 02/24/2012 04:53 PM, Andreas Färber wrote:
>>> Am 24.02.2012 23:18, schrieb Meador Inge:
>>>> Fixing a simple typo, s/errno/err/, that caused
>>>> the error status from GDB semihosted system calls
>>>> to be returned incorrectly.
>>>>
>>>> Signed-off-by: Meador Inge <meadori@codesourcery.com>
>>>
>>> Nice catch!
>>>
>>> Reviewed-by: Andreas Färber <afaerber@suse.de>
>>>
>>> Andreas
>>>
>>>> ---
>>>> m68k-semi.c | 2 +-
>>>> 1 files changed, 1 insertions(+), 1 deletions(-)
>>>>
>>>> diff --git a/m68k-semi.c b/m68k-semi.c
>>>> index bab01ee..6d60ced 100644
>>>> --- a/m68k-semi.c
>>>> +++ b/m68k-semi.c
>>>> @@ -150,7 +150,7 @@ static void m68k_semi_cb(CPUState *env, target_ulong ret, target_ulong err)
>>>> }
>>>> /* FIXME - handle put_user() failure */
>>>> put_user_u32(ret, args);
>>>> - put_user_u32(errno, args + 4);
>>>> + put_user_u32(err, args + 4);
>>>> }
>>>>
>>>> #define ARG(n) \
>>>
>>
>>
>> --
>> Meador Inge
>> CodeSourcery / Mentor Embedded
>> http://www.mentor.com/embedded-software
>>
^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2012-10-29 10:03 UTC | newest]
Thread overview: 7+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-02-24 22:18 [Qemu-devel] [PATCH v1 1/1] m68k: Return semihosting errno values correctly Meador Inge
2012-02-24 22:53 ` Andreas Färber
2012-03-27 15:07 ` Meador Inge
2012-03-27 15:43 ` Peter Maydell
2012-03-27 15:51 ` Andreas Färber
2012-10-29 9:42 ` Peter Maydell
2012-10-29 10:03 ` [Qemu-devel] [Qemu-trivial] " Stefan Hajnoczi
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).