From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:49971) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SCYrf-0008MW-Oo for qemu-devel@nongnu.org; Tue, 27 Mar 2012 12:03:25 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1SCYrZ-0000wj-JM for qemu-devel@nongnu.org; Tue, 27 Mar 2012 12:03:19 -0400 Received: from mail-pb0-f45.google.com ([209.85.160.45]:59968) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SCYrZ-0000wA-5F for qemu-devel@nongnu.org; Tue, 27 Mar 2012 12:03:13 -0400 Received: by pbcuo5 with SMTP id uo5so479687pbc.4 for ; Tue, 27 Mar 2012 09:03:11 -0700 (PDT) Sender: Richard Henderson Message-ID: <4F71E4BD.6010401@twiddle.net> Date: Tue, 27 Mar 2012 09:03:09 -0700 From: Richard Henderson MIME-Version: 1.0 References: <1332840290-24553-1-git-send-email-proljc@gmail.com> <1332840290-24553-6-git-send-email-proljc@gmail.com> In-Reply-To: <1332840290-24553-6-git-send-email-proljc@gmail.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH V3 05/12] Add helper functions for MIPS DSP Arithmetic instructions List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Jia Liu Cc: qemu-devel@nongnu.org, aurelien@aurel32.net On 03/27/12 02:24, Jia Liu wrote: > +DEF_HELPER_FLAGS_2(addq_ph, TCG_CALL_CONST | TCG_CALL_PURE, i32, i32, i32) > +DEF_HELPER_FLAGS_2(addq_s_ph, TCG_CALL_CONST | TCG_CALL_PURE, i32, i32, i32) > +DEF_HELPER_FLAGS_2(addq_s_w, TCG_CALL_CONST | TCG_CALL_PURE, i32, i32, i32) > +DEF_HELPER_FLAGS_2(addu_qb, TCG_CALL_CONST | TCG_CALL_PURE, i32, i32, i32) As mentioned in the first mail, those of these functions that can set bits in DSPControl cannot be TCG_CALL_CONST | TCG_CALL_PURE. There are still plenty of these that *are* pure functions though. r~