From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:60248) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SCZ83-0005E8-55 for qemu-devel@nongnu.org; Tue, 27 Mar 2012 12:20:21 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1SCZ7w-0005kX-V3 for qemu-devel@nongnu.org; Tue, 27 Mar 2012 12:20:14 -0400 Received: from mail-pb0-f45.google.com ([209.85.160.45]:61194) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SCZ7w-0005jX-LK for qemu-devel@nongnu.org; Tue, 27 Mar 2012 12:20:08 -0400 Received: by pbcuo5 with SMTP id uo5so501482pbc.4 for ; Tue, 27 Mar 2012 09:20:06 -0700 (PDT) Sender: Paolo Bonzini Message-ID: <4F71E8AE.9030504@redhat.com> Date: Tue, 27 Mar 2012 18:19:58 +0200 From: Paolo Bonzini MIME-Version: 1.0 References: <1332769612-4247-1-git-send-email-afaerber@suse.de> In-Reply-To: <1332769612-4247-1-git-send-email-afaerber@suse.de> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Subject: Re: [Qemu-devel] [PATCH RFC 0/3] qom: Generalize qdev init to "realize" List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: =?UTF-8?B?QW5kcmVhcyBGw6RyYmVy?= Cc: qemu-devel@nongnu.org, Anthony Liguori , Wanpeng Li Il 26/03/2012 15:46, Andreas Färber ha scritto: > Hello Anthony, > > Here's a mini series introducing ObjectClass::realize(Object *) and > forwarding it to existing DeviceClass::init(DeviceState *). I think a major difference between realize and init should be that the realize property also propagates down the whole composition tree (in pre-order for setting to true, and post-order for setting to false). An important, related point is whether the composition tree should be created before or after realize/init. Right now the few examples in the tree do it after, but this sounds wrong to me and would block the above auto-propagation. Paolo