From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:56021) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SCZTC-0002Wy-4L for qemu-devel@nongnu.org; Tue, 27 Mar 2012 12:42:10 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1SCZT5-0003Zg-SV for qemu-devel@nongnu.org; Tue, 27 Mar 2012 12:42:05 -0400 Received: from mx1.redhat.com ([209.132.183.28]:33542) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SCZT5-0003Xb-L5 for qemu-devel@nongnu.org; Tue, 27 Mar 2012 12:41:59 -0400 Message-ID: <4F71EDC9.7050503@redhat.com> Date: Tue, 27 Mar 2012 18:41:45 +0200 From: Paolo Bonzini MIME-Version: 1.0 References: <1332769612-4247-1-git-send-email-afaerber@suse.de> <4F71E8AE.9030504@redhat.com> <4F71EABB.1030004@codemonkey.ws> In-Reply-To: <4F71EABB.1030004@codemonkey.ws> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH RFC 0/3] qom: Generalize qdev init to "realize" List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Anthony Liguori Cc: Wanpeng Li , =?UTF-8?B?QW5kcmVhcyBGw6RyYmVy?= , qemu-devel@nongnu.org Il 27/03/2012 18:28, Anthony Liguori ha scritto: > > Yes, I haven't reviewed this series yet, but my expectation would be > that realize propagates and that the default implementation of > DeviceClass::realize() would explicitly *not* propagate and instead just > call ::init. > > Likewise, unrealize() should do the same with reset(). Andreas, since this came up three times in three different threads today, I sent my series to give all objects a canonical path. With that series and yours together, you should be able to experiment with pushing qdev_init out of functions such as rtc_init, and instead just set realize=true for the root (or the /machine container added in that series). Paolo