From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:56252) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SCZU5-0003H7-OU for qemu-devel@nongnu.org; Tue, 27 Mar 2012 12:43:07 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1SCZTx-0003v4-HS for qemu-devel@nongnu.org; Tue, 27 Mar 2012 12:43:01 -0400 Received: from mail-yw0-f45.google.com ([209.85.213.45]:61769) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SCZTx-0003uo-D4 for qemu-devel@nongnu.org; Tue, 27 Mar 2012 12:42:53 -0400 Received: by yhoo21 with SMTP id o21so122574yho.4 for ; Tue, 27 Mar 2012 09:42:52 -0700 (PDT) Message-ID: <4F71EE09.8000407@codemonkey.ws> Date: Tue, 27 Mar 2012 11:42:49 -0500 From: Anthony Liguori MIME-Version: 1.0 References: <1332866328-25443-1-git-send-email-pbonzini@redhat.com> In-Reply-To: <1332866328-25443-1-git-send-email-pbonzini@redhat.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 0/4] qdev: give all devices a canonical QOM path List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Paolo Bonzini Cc: aliguori@linux.vnet.ibm.com, andreas.faerber@web.de, qemu-devel@nongnu.org On 03/27/2012 11:38 AM, Paolo Bonzini wrote: > A strong limitation of QOM right now is that unconverted ports > (e.g. all...) do not give a canonical path to devices that are > part of the board. This in turn makes it impossible to replace > PROP_PTR with a QOM link for example. > > This series fixes this by putting all such devices under a > /unattached container. Excellent! Thanks for doing this. Regards, Anthony Liguori > > The problem is when to do this. qdev_init is a good place, but it > requires the composition tree to be in order by the time we call it. > This is not the case so far, but it can be changed easily (patch 2) at > the cost of removing most of the few composition examples that are in the > tree. This change is also necessary so that a single set of the topmost > realize property can propagate all the way down the composition tree, > as agreed on the mailing list. > > At the end of the series, all devices are moved to /machine > in order to avoid cluttering too much the QOM root. > > Paolo Bonzini (4): > qom: add container_get > qdev: add children before qdev_init > qdev: give all devices a canonical path > qdev: put all devices under /machine > > hw/pc_piix.c | 18 +----------------- > hw/piix_pci.c | 3 +-- > hw/ppc_prep.c | 2 +- > hw/qdev-monitor.c | 16 ++++++---------- > hw/qdev.c | 16 +++++++++++++--- > include/qemu/object.h | 24 ++++++++++++++++++++++++ > qom/container.c | 23 +++++++++++++++++++++++ > qom/object.c | 33 +++++++++++++++++---------------- > 8 files changed, 86 insertions(+), 49 deletions(-) >