From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:47134) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SCZtk-0006z7-BT for qemu-devel@nongnu.org; Tue, 27 Mar 2012 13:09:34 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1SCZtf-000353-CE for qemu-devel@nongnu.org; Tue, 27 Mar 2012 13:09:31 -0400 Message-ID: <4F71F442.7080201@redhat.com> Date: Tue, 27 Mar 2012 11:09:22 -0600 From: Eric Blake MIME-Version: 1.0 References: <1332867470-29780-1-git-send-email-sw@weilnetz.de> In-Reply-To: <1332867470-29780-1-git-send-email-sw@weilnetz.de> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="------------enigBB5993A9ABD0477CBB4F22CB" Subject: Re: [Qemu-devel] [PATCH] Fix conversion from lower to upper case with Turkish locale List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Stefan Weil Cc: qemu-trivial@nongnu.org, Peter Maydell , Andreas Faerber , qemu-devel@nongnu.org, Emre Ersin This is an OpenPGP/MIME signed message (RFC 2440 and 3156) --------------enigBB5993A9ABD0477CBB4F22CB Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On 03/27/2012 10:57 AM, Stefan Weil wrote: > Some locale settings let make fail or create wrong results > because tr '[:lower:]' '[:upper:]' which is used to convert > from lower to upper case depends on the locale. >=20 > With locale tr_TR.UTF-8, lower case 'i' is not converted to 'I'. > This results in wrong entries in config-host.h like these ones: >=20 > #define CONFIG_QEMU_PREFiX "/usr/local" > #define CONFIG_QEMU_BiNDiR "/usr/local/bin" > for card in $audio_card_list; do > - def=3DCONFIG_`echo $card | tr '[:lower:]' '[:upper:]'` > + def=3DCONFIG_`echo $card | tr '[a-z]' '[A-Z]'` NACK. POSIX says that 'tr a-z' is unspecified outside of the POSIX locale, but without setting LC_ALL=3DC, you aren't guaranteeing the POSIX= locale. If you want to be portable without use of [:lower:], you have to spell it out, with abcdefghijklmnopqrstuvwxyz. --=20 Eric Blake eblake@redhat.com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --------------enigBB5993A9ABD0477CBB4F22CB Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.12 (GNU/Linux) Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/ iQEcBAEBCAAGBQJPcfRCAAoJEKeha0olJ0NqD2EH/0V/MM4t5u9tgcV4FPfMfMj0 2Cuj95YKo1zcXbxlKFWuXaEo4UZNNxkKcwCEjGKFwYjaRv2z7dew0ouz39Xv9Rlk S6g9rbL0cJlAz6y5OLBZ20OrMZLV4nL4iQhR5RC1NC+fqJL9pC0NMYBlT+dh5ZvU l7z+JVMfI5C5HJ6AXfwwX0K/chh9Vmhbon8vgM5qknJTwKrk7EgwTDBIFZCYvDjn 3GrsiCT2i6LLNDwXDWcpMyYl3Sfofg2l7Kwx4cy8ZNgMydSnihXDkQNabXxB+3tZ LgMgTBVHE3jG3+jCRdjsmXm7MJRrHZi/R8laRtYHqjDe/BOnoB5U/jqE8qg39vk= =KQt9 -----END PGP SIGNATURE----- --------------enigBB5993A9ABD0477CBB4F22CB--