From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:60041) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SCaHW-0002xu-LM for qemu-devel@nongnu.org; Tue, 27 Mar 2012 13:34:12 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1SCaHQ-0001wx-Nv for qemu-devel@nongnu.org; Tue, 27 Mar 2012 13:34:06 -0400 Message-ID: <4F71FA03.8010807@redhat.com> Date: Tue, 27 Mar 2012 11:33:55 -0600 From: Eric Blake MIME-Version: 1.0 References: <1332869033-5558-1-git-send-email-sw@weilnetz.de> In-Reply-To: <1332869033-5558-1-git-send-email-sw@weilnetz.de> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="------------enig2B54DA4D955A4399E09134A7" Subject: Re: [Qemu-devel] [PATCH v2] Fix conversion from lower to upper case with Turkish locale List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Stefan Weil Cc: qemu-trivial@nongnu.org, Peter Maydell , Andreas Faerber , qemu-devel@nongnu.org, Emre Ersin This is an OpenPGP/MIME signed message (RFC 2440 and 3156) --------------enig2B54DA4D955A4399E09134A7 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On 03/27/2012 11:23 AM, Stefan Weil wrote: > Some locale settings let make fail or create wrong results > because tr '[:lower:]' '[:upper:]' which is used to convert > from lower to upper case depends on the locale. >=20 =2E.. >=20 > v2: > POSIX says that 'tr a-z' is unspecified outside of the POSIX > locale, so we must set LC_ALL=3DC to make sure that we are using > POSIX (hint from Eric Blake, thanks). >=20 > Signed-off-by: Stefan Weil > --- > configure | 6 +++--- > scripts/create_config | 6 +++--- > scripts/tracetool | 4 ++-- > 3 files changed, 8 insertions(+), 8 deletions(-) Not being a regular reviewer on this list, I'm not sure I know the subtle difference between 'Acked-by' and 'Reviewed-by' to know which one I should be adding; but this patch resolves my objection on v1. [Side note - POSIX actually requires: tr a-z A-Z to do the 26-letter case conversion, and that use of '[a-z]' means you are transliterating 28 characters, by changing '[' and ']' to themselves. But on older Solaris tr, you had to provide the [] to get range expansion rather than transliteration of a literal '-', so your patch is the right approach for maximal portability] --=20 Eric Blake eblake@redhat.com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --------------enig2B54DA4D955A4399E09134A7 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.12 (GNU/Linux) Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/ iQEcBAEBCAAGBQJPcfoDAAoJEKeha0olJ0NqFyUH/3d2+mpw5MAbV1bR5hvsrA/o +dNxuSrfhT1GkNXf2AvdTNfPQsAch0Xh8f8Sg/3GTwBAyt7a9l3PJxfdiw8EgcY2 e7asb4oKH5P15s8Afclw7Ga7XAiqcsJjfpwtV8OH/13L0y1XM3XfPuD7vuex+/iE AvqkGHhucF7xwKJ9WxCxjfeUiWY7cCf0kJ69RcHBzvhpydp8nYI0ur/fszilQyZM Dk2r3kvky+4eTwlZjmb2iDcgbAtikV/QrOpDza7puFHOmhjIBDySpvWtEhA5Y4sH TYBkxKxHnfLpKoGIjsFxuafCn5Iz437KvHs0iL63sNVqvSzxq1Ih2ZdZm+q8uV4= =3bQu -----END PGP SIGNATURE----- --------------enig2B54DA4D955A4399E09134A7--