From: Richard Henderson <rth@twiddle.net>
To: Jia Liu <proljc@gmail.com>
Cc: qemu-devel@nongnu.org, aurelien@aurel32.net
Subject: Re: [Qemu-devel] [PATCH V3 09/12] Add helper functions for MIPS DSP Compare-Pick instructions
Date: Tue, 27 Mar 2012 10:42:24 -0700 [thread overview]
Message-ID: <4F71FC00.3060700@twiddle.net> (raw)
In-Reply-To: <1332840290-24553-10-git-send-email-proljc@gmail.com>
On 03/27/12 02:24, Jia Liu wrote:
> + uint32_t cc3 = 0, cc2 = 0, cc1 = 0, cc0 = 0;
> + uint32_t flag;
...
> + if (rs3 == rt3)
> + cc3 = 1;
Clearer as "cc3 = (rs3 == rt3);", etc.
I begin to wonder if it wouldn't be better to model the DSPControl
word as individual variables of their respective fields. That way
you don't need to involve ENV so much.
E.g.
Assume cpu_dspcc is a TCGv_i32 variable containing 4 bits.
case CMPGU_COND_QB:
gen_helper_cmpdu_cond_qb(cpu_gr[rd], cpu_gr[rs], cpu_gr[rt]);
break;
case CMPGDU_COND_QB:
gen_helper_cmpdu_cond_qb(cpu_dspcc, cpu_gr[rs], cpu_gr[rt]);
tcg_gen_mov(cpu_gr[rd], cpu_dspcc);
break;
No need for two separate helpers. Even if you don't decide to split
the field, you probably don't want to duplicate so much code in the
helpers file.
r~
next prev parent reply other threads:[~2012-03-27 17:42 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-03-27 9:24 [Qemu-devel] [PATCH V3 00/12] Qemu MIPS ASE DSP Support Jia Liu
2012-03-27 9:24 ` [Qemu-devel] [PATCH V3 01/12] add MIPS DSP internal functions Jia Liu
2012-03-27 15:33 ` Richard Henderson
2012-03-28 2:03 ` Jia Liu
2012-03-29 11:16 ` Richard Henderson
2012-03-27 9:24 ` [Qemu-devel] [PATCH V3 02/12] Use correct acc value to index cpu_HI/cpu_LO rather than using a fix number Jia Liu
2012-03-27 15:34 ` Richard Henderson
2012-03-27 9:24 ` [Qemu-devel] [PATCH V3 03/12] Add MIPS DSP Branch instruction Support Jia Liu
2012-03-27 15:46 ` Richard Henderson
2012-03-28 1:27 ` Jia Liu
2012-03-27 9:24 ` [Qemu-devel] [PATCH V3 04/12] Add MIPS DSP Load instructions Support Jia Liu
2012-03-27 15:49 ` Richard Henderson
2012-03-28 1:46 ` Jia Liu
2012-03-27 9:24 ` [Qemu-devel] [PATCH V3 05/12] Add helper functions for MIPS DSP Arithmetic instructions Jia Liu
2012-03-27 16:03 ` Richard Henderson
2012-03-28 1:45 ` Jia Liu
2012-03-27 9:24 ` [Qemu-devel] [PATCH V3 06/12] Add helper functions for MIPS DSP GPR-Based Shift instructions Jia Liu
2012-03-27 16:11 ` Richard Henderson
2012-03-28 1:43 ` Jia Liu
2012-03-29 13:09 ` Richard Henderson
2012-03-27 9:24 ` [Qemu-devel] [PATCH V3 07/12] Add helper functions for MIPS DSP Multiply instructions Jia Liu
2012-03-27 9:24 ` [Qemu-devel] [PATCH V3 08/12] Add helper functions for MIPS DSP Bit/Manipulation instructions Jia Liu
2012-03-27 16:23 ` Richard Henderson
2012-03-28 1:47 ` Jia Liu
2012-03-27 9:24 ` [Qemu-devel] [PATCH V3 09/12] Add helper functions for MIPS DSP Compare-Pick instructions Jia Liu
2012-03-27 17:42 ` Richard Henderson [this message]
2012-03-28 1:52 ` Jia Liu
2012-03-27 9:24 ` [Qemu-devel] [PATCH V3 10/12] Add helper functions for MIPS DSP Accumulator and DSPControl Access instrutions helpers Jia Liu
2012-03-27 9:24 ` [Qemu-devel] [PATCH V3 11/12] Handle MIPS DSP instructions in target-mips/translate.c Jia Liu
2012-03-27 17:48 ` Richard Henderson
2012-03-28 1:36 ` Jia Liu
2012-03-29 13:20 ` Richard Henderson
2012-03-27 9:24 ` [Qemu-devel] [PATCH V3 12/12] add MIPS DSP testcases Jia Liu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4F71FC00.3060700@twiddle.net \
--to=rth@twiddle.net \
--cc=aurelien@aurel32.net \
--cc=proljc@gmail.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).