From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:44573) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SCaVJ-0000E6-JK for qemu-devel@nongnu.org; Tue, 27 Mar 2012 13:48:27 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1SCaVE-00062r-Pk for qemu-devel@nongnu.org; Tue, 27 Mar 2012 13:48:21 -0400 Received: from mail-pb0-f45.google.com ([209.85.160.45]:56902) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SCaVE-00062g-Fy for qemu-devel@nongnu.org; Tue, 27 Mar 2012 13:48:16 -0400 Received: by pbcuo5 with SMTP id uo5so605043pbc.4 for ; Tue, 27 Mar 2012 10:48:14 -0700 (PDT) Sender: Richard Henderson Message-ID: <4F71FD5C.809@twiddle.net> Date: Tue, 27 Mar 2012 10:48:12 -0700 From: Richard Henderson MIME-Version: 1.0 References: <1332840290-24553-1-git-send-email-proljc@gmail.com> <1332840290-24553-12-git-send-email-proljc@gmail.com> In-Reply-To: <1332840290-24553-12-git-send-email-proljc@gmail.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH V3 11/12] Handle MIPS DSP instructions in target-mips/translate.c List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Jia Liu Cc: qemu-devel@nongnu.org, aurelien@aurel32.net On 03/27/12 02:24, Jia Liu wrote: > Handle MIPS DSP instructions in target-mips/translate.c. > > Signed-off-by: Jia Liu This patch should have been split as well, adding translations of the insns at the same time you add the helpers. That said, the actual code looks ok. r~