* [Qemu-devel] [PATCH v1 1/1] syscall: #ifdef newer RLIMIT_* codes
@ 2012-02-20 18:26 Meador Inge
2012-02-20 19:38 ` Andreas Färber
0 siblings, 1 reply; 5+ messages in thread
From: Meador Inge @ 2012-02-20 18:26 UTC (permalink / raw)
To: qemu-devel
Commit e22b7015353be824620b1f0f5e32a8575b898a8c added the translation
from target to host RLIMIT_* codes, but some of the added codes are
only available on newer version of Linux (as documented in 'getrlimit(2)').
Signed-off-by: Meador Inge <meadori@codesourcery.com>
---
linux-user/syscall.c | 12 ++++++++++++
1 files changed, 12 insertions(+), 0 deletions(-)
diff --git a/linux-user/syscall.c b/linux-user/syscall.c
index 8a11213..1986238 100644
--- a/linux-user/syscall.c
+++ b/linux-user/syscall.c
@@ -996,20 +996,32 @@ static inline int target_to_host_resource(int code)
return RLIMIT_LOCKS;
case TARGET_RLIMIT_MEMLOCK:
return RLIMIT_MEMLOCK;
+/* >= Linux 2.6.8 */
+#ifdef RLIMIT_MSGQUEUE
case TARGET_RLIMIT_MSGQUEUE:
return RLIMIT_MSGQUEUE;
+#endif
+/* >= Linux 2.6.12 */
+#ifdef RLIMIT_NICE
case TARGET_RLIMIT_NICE:
return RLIMIT_NICE;
+#endif
case TARGET_RLIMIT_NOFILE:
return RLIMIT_NOFILE;
case TARGET_RLIMIT_NPROC:
return RLIMIT_NPROC;
case TARGET_RLIMIT_RSS:
return RLIMIT_RSS;
+/* >= Linux 2.6.12 */
+#ifdef RLIMIT_RTPRIO
case TARGET_RLIMIT_RTPRIO:
return RLIMIT_RTPRIO;
+#endif
+/* >= Linux 2.6.8 */
+#ifdef RLIMIT_SIGPENDING
case TARGET_RLIMIT_SIGPENDING:
return RLIMIT_SIGPENDING;
+#endif
case TARGET_RLIMIT_STACK:
return RLIMIT_STACK;
default:
--
1.7.7.6
^ permalink raw reply related [flat|nested] 5+ messages in thread* Re: [Qemu-devel] [PATCH v1 1/1] syscall: #ifdef newer RLIMIT_* codes
2012-02-20 18:26 [Qemu-devel] [PATCH v1 1/1] syscall: #ifdef newer RLIMIT_* codes Meador Inge
@ 2012-02-20 19:38 ` Andreas Färber
2012-03-27 15:08 ` Meador Inge
0 siblings, 1 reply; 5+ messages in thread
From: Andreas Färber @ 2012-02-20 19:38 UTC (permalink / raw)
To: Meador Inge; +Cc: Riku Voipio, qemu-devel
Am 20.02.2012 19:26, schrieb Meador Inge:
> Commit e22b7015353be824620b1f0f5e32a8575b898a8c added the translation
> from target to host RLIMIT_* codes, but some of the added codes are
> only available on newer version of Linux (as documented in 'getrlimit(2)').
>
> Signed-off-by: Meador Inge <meadori@codesourcery.com>
Reviewed-by: Andreas Färber <afaerber@suse.de>
CC'ing the linux-user maintainer.
Andreas
> ---
> linux-user/syscall.c | 12 ++++++++++++
> 1 files changed, 12 insertions(+), 0 deletions(-)
>
> diff --git a/linux-user/syscall.c b/linux-user/syscall.c
> index 8a11213..1986238 100644
> --- a/linux-user/syscall.c
> +++ b/linux-user/syscall.c
> @@ -996,20 +996,32 @@ static inline int target_to_host_resource(int code)
> return RLIMIT_LOCKS;
> case TARGET_RLIMIT_MEMLOCK:
> return RLIMIT_MEMLOCK;
> +/* >= Linux 2.6.8 */
> +#ifdef RLIMIT_MSGQUEUE
> case TARGET_RLIMIT_MSGQUEUE:
> return RLIMIT_MSGQUEUE;
> +#endif
> +/* >= Linux 2.6.12 */
> +#ifdef RLIMIT_NICE
> case TARGET_RLIMIT_NICE:
> return RLIMIT_NICE;
> +#endif
> case TARGET_RLIMIT_NOFILE:
> return RLIMIT_NOFILE;
> case TARGET_RLIMIT_NPROC:
> return RLIMIT_NPROC;
> case TARGET_RLIMIT_RSS:
> return RLIMIT_RSS;
> +/* >= Linux 2.6.12 */
> +#ifdef RLIMIT_RTPRIO
> case TARGET_RLIMIT_RTPRIO:
> return RLIMIT_RTPRIO;
> +#endif
> +/* >= Linux 2.6.8 */
> +#ifdef RLIMIT_SIGPENDING
> case TARGET_RLIMIT_SIGPENDING:
> return RLIMIT_SIGPENDING;
> +#endif
> case TARGET_RLIMIT_STACK:
> return RLIMIT_STACK;
> default:
--
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 16746 AG Nürnberg
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [Qemu-devel] [PATCH v1 1/1] syscall: #ifdef newer RLIMIT_* codes
2012-02-20 19:38 ` Andreas Färber
@ 2012-03-27 15:08 ` Meador Inge
2012-03-27 17:15 ` Riku Voipio
0 siblings, 1 reply; 5+ messages in thread
From: Meador Inge @ 2012-03-27 15:08 UTC (permalink / raw)
To: qemu-devel; +Cc: Riku Voipio, Andreas Färber
Ping.
On 02/20/2012 01:38 PM, Andreas Färber wrote:
> Am 20.02.2012 19:26, schrieb Meador Inge:
>> Commit e22b7015353be824620b1f0f5e32a8575b898a8c added the translation
>> from target to host RLIMIT_* codes, but some of the added codes are
>> only available on newer version of Linux (as documented in 'getrlimit(2)').
>>
>> Signed-off-by: Meador Inge <meadori@codesourcery.com>
>
> Reviewed-by: Andreas Färber <afaerber@suse.de>
>
> CC'ing the linux-user maintainer.
>
> Andreas
>
>> ---
>> linux-user/syscall.c | 12 ++++++++++++
>> 1 files changed, 12 insertions(+), 0 deletions(-)
>>
>> diff --git a/linux-user/syscall.c b/linux-user/syscall.c
>> index 8a11213..1986238 100644
>> --- a/linux-user/syscall.c
>> +++ b/linux-user/syscall.c
>> @@ -996,20 +996,32 @@ static inline int target_to_host_resource(int code)
>> return RLIMIT_LOCKS;
>> case TARGET_RLIMIT_MEMLOCK:
>> return RLIMIT_MEMLOCK;
>> +/* >= Linux 2.6.8 */
>> +#ifdef RLIMIT_MSGQUEUE
>> case TARGET_RLIMIT_MSGQUEUE:
>> return RLIMIT_MSGQUEUE;
>> +#endif
>> +/* >= Linux 2.6.12 */
>> +#ifdef RLIMIT_NICE
>> case TARGET_RLIMIT_NICE:
>> return RLIMIT_NICE;
>> +#endif
>> case TARGET_RLIMIT_NOFILE:
>> return RLIMIT_NOFILE;
>> case TARGET_RLIMIT_NPROC:
>> return RLIMIT_NPROC;
>> case TARGET_RLIMIT_RSS:
>> return RLIMIT_RSS;
>> +/* >= Linux 2.6.12 */
>> +#ifdef RLIMIT_RTPRIO
>> case TARGET_RLIMIT_RTPRIO:
>> return RLIMIT_RTPRIO;
>> +#endif
>> +/* >= Linux 2.6.8 */
>> +#ifdef RLIMIT_SIGPENDING
>> case TARGET_RLIMIT_SIGPENDING:
>> return RLIMIT_SIGPENDING;
>> +#endif
>> case TARGET_RLIMIT_STACK:
>> return RLIMIT_STACK;
>> default:
>
--
Meador Inge
CodeSourcery / Mentor Embedded
http://www.mentor.com/embedded-software
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [Qemu-devel] [PATCH v1 1/1] syscall: #ifdef newer RLIMIT_* codes
2012-03-27 15:08 ` Meador Inge
@ 2012-03-27 17:15 ` Riku Voipio
2012-03-27 20:20 ` Meador Inge
0 siblings, 1 reply; 5+ messages in thread
From: Riku Voipio @ 2012-03-27 17:15 UTC (permalink / raw)
To: Meador Inge; +Cc: qemu-devel, Andreas Färber
Hi,
Do we really need this? 2.6.12 came out in 2005, even oldest supported
RHEL (5) is minimum 2.6.18 these days.
Riku
On Tue, Mar 27, 2012 at 10:08:03AM -0500, Meador Inge wrote:
> Ping.
>
> On 02/20/2012 01:38 PM, Andreas Färber wrote:
> > Am 20.02.2012 19:26, schrieb Meador Inge:
> >> Commit e22b7015353be824620b1f0f5e32a8575b898a8c added the translation
> >> from target to host RLIMIT_* codes, but some of the added codes are
> >> only available on newer version of Linux (as documented in 'getrlimit(2)').
> >>
> >> Signed-off-by: Meador Inge <meadori@codesourcery.com>
> >
> > Reviewed-by: Andreas Färber <afaerber@suse.de>
> >
> > CC'ing the linux-user maintainer.
> >
> > Andreas
> >
> >> ---
> >> linux-user/syscall.c | 12 ++++++++++++
> >> 1 files changed, 12 insertions(+), 0 deletions(-)
> >>
> >> diff --git a/linux-user/syscall.c b/linux-user/syscall.c
> >> index 8a11213..1986238 100644
> >> --- a/linux-user/syscall.c
> >> +++ b/linux-user/syscall.c
> >> @@ -996,20 +996,32 @@ static inline int target_to_host_resource(int code)
> >> return RLIMIT_LOCKS;
> >> case TARGET_RLIMIT_MEMLOCK:
> >> return RLIMIT_MEMLOCK;
> >> +/* >= Linux 2.6.8 */
> >> +#ifdef RLIMIT_MSGQUEUE
> >> case TARGET_RLIMIT_MSGQUEUE:
> >> return RLIMIT_MSGQUEUE;
> >> +#endif
> >> +/* >= Linux 2.6.12 */
> >> +#ifdef RLIMIT_NICE
> >> case TARGET_RLIMIT_NICE:
> >> return RLIMIT_NICE;
> >> +#endif
> >> case TARGET_RLIMIT_NOFILE:
> >> return RLIMIT_NOFILE;
> >> case TARGET_RLIMIT_NPROC:
> >> return RLIMIT_NPROC;
> >> case TARGET_RLIMIT_RSS:
> >> return RLIMIT_RSS;
> >> +/* >= Linux 2.6.12 */
> >> +#ifdef RLIMIT_RTPRIO
> >> case TARGET_RLIMIT_RTPRIO:
> >> return RLIMIT_RTPRIO;
> >> +#endif
> >> +/* >= Linux 2.6.8 */
> >> +#ifdef RLIMIT_SIGPENDING
> >> case TARGET_RLIMIT_SIGPENDING:
> >> return RLIMIT_SIGPENDING;
> >> +#endif
> >> case TARGET_RLIMIT_STACK:
> >> return RLIMIT_STACK;
> >> default:
> >
>
>
> --
> Meador Inge
> CodeSourcery / Mentor Embedded
> http://www.mentor.com/embedded-software
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [Qemu-devel] [PATCH v1 1/1] syscall: #ifdef newer RLIMIT_* codes
2012-03-27 17:15 ` Riku Voipio
@ 2012-03-27 20:20 ` Meador Inge
0 siblings, 0 replies; 5+ messages in thread
From: Meador Inge @ 2012-03-27 20:20 UTC (permalink / raw)
To: Riku Voipio; +Cc: qemu-devel, Andreas Färber
On 03/27/2012 12:15 PM, Riku Voipio wrote:
> Hi,
>
> Do we really need this? 2.6.12 came out in 2005, even oldest supported
> RHEL (5) is minimum 2.6.18 these days.
The development environment I am working with uses a RHEL 3 compatible sysroot
(RHEL 3 is currently marked with "extended life cycle support"). So, I
definitely need it :-) (and yes I know that this sysroot is ancient). I don't
know if others are using such old development sysroots. The changes are
minimal and while it would be great to have this applied upstream I do
understand if you want to NACK.
--
Meador Inge
CodeSourcery / Mentor Embedded
http://www.mentor.com/embedded-software
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2012-03-27 20:20 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-02-20 18:26 [Qemu-devel] [PATCH v1 1/1] syscall: #ifdef newer RLIMIT_* codes Meador Inge
2012-02-20 19:38 ` Andreas Färber
2012-03-27 15:08 ` Meador Inge
2012-03-27 17:15 ` Riku Voipio
2012-03-27 20:20 ` Meador Inge
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).