From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([208.118.235.92]:51869)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <afaerber@suse.de>) id 1SCtDK-0002sa-Gw
	for qemu-devel@nongnu.org; Wed, 28 Mar 2012 09:47:08 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <afaerber@suse.de>) id 1SCtDI-0004sY-Jt
	for qemu-devel@nongnu.org; Wed, 28 Mar 2012 09:47:02 -0400
Received: from cantor2.suse.de ([195.135.220.15]:44901 helo=mx2.suse.de)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <afaerber@suse.de>) id 1SCtDI-0004qx-Dh
	for qemu-devel@nongnu.org; Wed, 28 Mar 2012 09:47:00 -0400
Message-ID: <4F731652.4060905@suse.de>
Date: Wed, 28 Mar 2012 15:46:58 +0200
From: =?UTF-8?B?QW5kcmVhcyBGw6RyYmVy?= <afaerber@suse.de>
MIME-Version: 1.0
References: <1332782909-28412-1-git-send-email-afaerber@suse.de>
	<1332782909-28412-3-git-send-email-afaerber@suse.de>
	<CAFEAcA8HT+_u_20dYrLC6OC33cnOTSutHRJWkp5vu2ajOGRvNA@mail.gmail.com>
In-Reply-To: <CAFEAcA8HT+_u_20dYrLC6OC33cnOTSutHRJWkp5vu2ajOGRvNA@mail.gmail.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
Subject: Re: [Qemu-devel] [PATCH v6 2/2] target-arm: Minimalistic CPU
	QOM'ification
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Peter Maydell <peter.maydell@linaro.org>
Cc: Max Filippov <jcmvbkbc@gmail.com>, qemu-devel@nongnu.org, Anthony Liguori <anthony@codemonkey.ws>, Paul Brook <paul@codesourcery.com>

Am 28.03.2012 15:40, schrieb Peter Maydell:
> On 26 March 2012 18:28, Andreas F=C3=A4rber <afaerber@suse.de> wrote:
>=20
>> +static void arm_cpu_reset(CPUState *c)
>> +{
>> +    ARMCPU *cpu =3D ARM_CPU(c);
>> +    ARMCPUClass *class =3D ARM_CPU_GET_CLASS(cpu);
>> +
>> +    class->parent_reset(c);
>=20
> I thought we were avoiding 'class' in favour of 'klass'?

Max complained about that and no one argued against him, so I avoided it
in the .c file where it's not strictly necessary. It's really only
necessary in the headers. But I don't mind either way.

For me, the convention is cpu_class =3D> CPUClass, so it would be unwise
here, thus one of class, clazz, klass.

>> +static const TypeInfo arm_cpu_type_info =3D {
>> +    .name =3D TYPE_ARM_CPU,
>> +    .parent =3D TYPE_CPU,
>> +    .instance_size =3D sizeof(ARMCPU),
>> +    .abstract =3D false, /* TODO Reconsider once cp15 reworked. */
>=20
> As it happens I'm planning to create the per-implementation
> subclasses first and do the cp15 rework second.

Suggest a rephrase? :)

Andreas

--=20
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 N=C3=BCrnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imend=C3=B6rffer; HRB 16746 AG N=C3=BC=
rnberg