From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:41915) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SCtFl-0004UW-K9 for qemu-devel@nongnu.org; Wed, 28 Mar 2012 09:49:39 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1SCtFd-0005bz-FJ for qemu-devel@nongnu.org; Wed, 28 Mar 2012 09:49:33 -0400 Received: from cantor2.suse.de ([195.135.220.15]:45269 helo=mx2.suse.de) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SCtFd-0005bl-8v for qemu-devel@nongnu.org; Wed, 28 Mar 2012 09:49:25 -0400 Message-ID: <4F7316E3.6020807@suse.de> Date: Wed, 28 Mar 2012 15:49:23 +0200 From: =?ISO-8859-1?Q?Andreas_F=E4rber?= MIME-Version: 1.0 References: <1332782909-28412-1-git-send-email-afaerber@suse.de> <1332782909-28412-3-git-send-email-afaerber@suse.de> In-Reply-To: Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH v6 2/2] target-arm: Minimalistic CPU QOM'ification List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Max Filippov Cc: Peter Maydell , qemu-devel@nongnu.org, Paul Brook Am 28.03.2012 15:46, schrieb Max Filippov: >>> +static void arm_cpu_reset(CPUState *c) >>> +{ >>> + ARMCPU *cpu =3D ARM_CPU(c); >>> + ARMCPUClass *class =3D ARM_CPU_GET_CLASS(cpu); >>> + >>> + class->parent_reset(c); >> >> I thought we were avoiding 'class' in favour of 'klass'? >=20 > I have suggested it once and I can only say it again, > please, call it 'cpu_class'. It is the least surprising name. No, cpu_class is being used for a different class, CPUClass, when twiddling with reset handlers of the parent class, for instance. We could call it arm_cpu_class, but is that any better? Andreas --=20 SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 N=FCrnberg, Germany GF: Jeff Hawn, Jennifer Guild, Felix Imend=F6rffer; HRB 16746 AG N=FCrnbe= rg