From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:35867) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SCtV8-00030b-Hc for qemu-devel@nongnu.org; Wed, 28 Mar 2012 10:05:39 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1SCtV3-0001AY-Kz for qemu-devel@nongnu.org; Wed, 28 Mar 2012 10:05:26 -0400 Received: from cantor2.suse.de ([195.135.220.15]:46375 helo=mx2.suse.de) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SCtV3-0001AL-E5 for qemu-devel@nongnu.org; Wed, 28 Mar 2012 10:05:21 -0400 Message-ID: <4F731A9F.6020003@suse.de> Date: Wed, 28 Mar 2012 16:05:19 +0200 From: =?ISO-8859-1?Q?Andreas_F=E4rber?= MIME-Version: 1.0 References: <1332782909-28412-1-git-send-email-afaerber@suse.de> <1332782909-28412-3-git-send-email-afaerber@suse.de> <4F7316E3.6020807@suse.de> In-Reply-To: Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH v6 2/2] target-arm: Minimalistic CPU QOM'ification List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Max Filippov Cc: Peter Maydell , qemu-devel@nongnu.org, Anthony Liguori , Paul Brook Am 28.03.2012 16:00, schrieb Max Filippov: >>>>> +static void arm_cpu_reset(CPUState *c) >>>>> +{ >>>>> + ARMCPU *cpu =3D ARM_CPU(c); >>>>> + ARMCPUClass *class =3D ARM_CPU_GET_CLASS(cpu); >>>>> + >>>>> + class->parent_reset(c); >>>> >>>> I thought we were avoiding 'class' in favour of 'klass'? >>> >>> I have suggested it once and I can only say it again, >>> please, call it 'cpu_class'. It is the least surprising name. >> >> No, cpu_class is being used for a different class, CPUClass, when >> twiddling with reset handlers of the parent class, for instance. >> >> We could call it arm_cpu_class, but is that any better? >=20 > There's no other class in this context, so why more specific name than > would be enough? > It's only a matter of long enough suffix, isn't it? My point was that using cpu_class for two very different things is not "least surprising" when reading patches containing minimal context. You don't always see the declaration, so I'd like to keep it consistent across functions. Andreas --=20 SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 N=FCrnberg, Germany GF: Jeff Hawn, Jennifer Guild, Felix Imend=F6rffer; HRB 16746 AG N=FCrnbe= rg