From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:35451) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SD2d2-0005kb-F7 for qemu-devel@nongnu.org; Wed, 28 Mar 2012 19:50:17 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1SD00z-0003te-Pj for qemu-devel@nongnu.org; Wed, 28 Mar 2012 17:02:48 -0400 Received: from e8.ny.us.ibm.com ([32.97.182.138]:48121) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SD00z-0003qO-Lf for qemu-devel@nongnu.org; Wed, 28 Mar 2012 17:02:45 -0400 Received: from /spool/local by e8.ny.us.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Wed, 28 Mar 2012 17:02:36 -0400 Received: from d01relay01.pok.ibm.com (d01relay01.pok.ibm.com [9.56.227.233]) by d01dlp01.pok.ibm.com (Postfix) with ESMTP id 851FF38C805A for ; Wed, 28 Mar 2012 17:02:31 -0400 (EDT) Received: from d01av04.pok.ibm.com (d01av04.pok.ibm.com [9.56.224.64]) by d01relay01.pok.ibm.com (8.13.8/8.13.8/NCO v10.0) with ESMTP id q2SL2Vkc197518 for ; Wed, 28 Mar 2012 17:02:31 -0400 Received: from d01av04.pok.ibm.com (loopback [127.0.0.1]) by d01av04.pok.ibm.com (8.14.4/8.13.1/NCO v10.0 AVout) with ESMTP id q2SL29s0024126 for ; Wed, 28 Mar 2012 17:02:10 -0400 Message-ID: <4F737C4C.80706@us.ibm.com> Date: Wed, 28 Mar 2012 16:02:04 -0500 From: Anthony Liguori MIME-Version: 1.0 References: <1332934907-24080-1-git-send-email-anthony.perard@citrix.com> <1332934907-24080-3-git-send-email-anthony.perard@citrix.com> <20120328185224.GB23805@phenom.dumpdata.com> In-Reply-To: <20120328185224.GB23805@phenom.dumpdata.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [Xen-devel] [PATCH V10 2/8] configure: Introduce --enable-xen-pci-passthrough. List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Konrad Rzeszutek Wilk Cc: Anthony PERARD , Xen Devel , QEMU-devel , Stefano Stabellini On 03/28/2012 01:52 PM, Konrad Rzeszutek Wilk wrote: > On Wed, Mar 28, 2012 at 12:41:41PM +0100, Anthony PERARD wrote: >> Signed-off-by: Anthony PERARD >> Acked-by: Stefano Stabellini > > > Reviewed-by: me. FYI, the scripts that I use to manage patches will collect Reviewed-by's and put them in the commit message so there's a proper review history in git. But 'Reviewed-by: me.' will lose it's context and your review will be forever lost to git history :-) So please use the proper tags. Regards, Anthony Liguori > >> --- >> configure | 25 +++++++++++++++++++++++++ >> 1 files changed, 25 insertions(+), 0 deletions(-) >> >> diff --git a/configure b/configure >> index 14ef738..cb7bc75 100755 >> --- a/configure >> +++ b/configure >> @@ -136,6 +136,7 @@ vnc_png="" >> vnc_thread="no" >> xen="" >> xen_ctrl_version="" >> +xen_pci_passthrough="" >> linux_aio="" >> cap_ng="" >> attr="" >> @@ -682,6 +683,10 @@ for opt do >> ;; >> --enable-xen) xen="yes" >> ;; >> + --disable-xen-pci-passthrough) xen_pci_passthrough="no" >> + ;; >> + --enable-xen-pci-passthrough) xen_pci_passthrough="yes" >> + ;; >> --disable-brlapi) brlapi="no" >> ;; >> --enable-brlapi) brlapi="yes" >> @@ -1034,6 +1039,8 @@ echo " (affects only QEMU, not qemu-img)" >> echo " --enable-mixemu enable mixer emulation" >> echo " --disable-xen disable xen backend driver support" >> echo " --enable-xen enable xen backend driver support" >> +echo " --disable-xen-pci-passthrough" >> +echo " --enable-xen-pci-passthrough" >> echo " --disable-brlapi disable BrlAPI" >> echo " --enable-brlapi enable BrlAPI" >> echo " --disable-vnc-tls disable TLS encryption for VNC server" >> @@ -1478,6 +1485,21 @@ EOF >> fi >> fi >> >> +if test "$xen_pci_passthrough" != "no"; then >> + if test "$xen" = "yes"&& test "$linux" = "yes"; then >> + xen_pci_passthrough=yes >> + else >> + if test "$xen_pci_passthrough" = "yes"; then >> + echo "ERROR" >> + echo "ERROR: User requested feature Xen PCI Passthrough" >> + echo "ERROR: but this feature require /sys from Linux" >> + echo "ERROR" >> + exit 1; >> + fi >> + xen_pci_passthrough=no >> + fi >> +fi >> + >> ########################################## >> # pkg-config probe >> >> @@ -3635,6 +3657,9 @@ case "$target_arch2" in >> if test "$xen" = "yes" -a "$target_softmmu" = "yes" ; then >> target_phys_bits=64 >> echo "CONFIG_XEN=y">> $config_target_mak >> + if test "$xen_pci_passthrough" = yes; then >> + echo "CONFIG_XEN_PCI_PASSTHROUGH=y">> "$config_target_mak" >> + fi >> else >> echo "CONFIG_NO_XEN=y">> $config_target_mak >> fi >> -- >> Anthony PERARD >> >> >> _______________________________________________ >> Xen-devel mailing list >> Xen-devel@lists.xen.org >> http://lists.xen.org/xen-devel >