From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:52250) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SD4if-0004CY-VA for qemu-devel@nongnu.org; Wed, 28 Mar 2012 22:04:11 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1SD4ie-0004Zs-9p for qemu-devel@nongnu.org; Wed, 28 Mar 2012 22:04:09 -0400 Received: from usrksweb02.endace.com ([174.143.168.194]:59620) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SD4ie-0004ZL-3J for qemu-devel@nongnu.org; Wed, 28 Mar 2012 22:04:08 -0400 Message-ID: <4F73C2FF.5000709@endace.com> Date: Thu, 29 Mar 2012 15:03:43 +1300 From: Alexey Korolev MIME-Version: 1.0 References: <1332908730.10322.4.camel@nzhmlwks0057.ad.endace.com> <1332908891.10322.7.camel@nzhmlwks0057.ad.endace.com> <4F73228B.4050804@redhat.com> In-Reply-To: <4F73228B.4050804@redhat.com> Content-Type: text/plain; charset="ISO-8859-1" Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [SeaBIOS] [PATCH 1/4] Add basic linked list operations List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Gerd Hoffmann Cc: sfd@endace.com, kevin@koconnor.net, seabios@seabios.org, qemu-devel@nongnu.org >> This linked list implementation is partially based on kernel code. So it >> should be quite stable > How about just copying the file? > > I've used the linux kernel list implementation elsewhere too and it > worked just fine with only minor tweaks (remove some likely()/unlikely() > macros IIRC). Right, in "take-2" Kevin has suggested very similar. It will be done as a separate patch, because the changes are not just about pciinit.c, they also simplify pmm.c and stack.c a bit. In this patch I'm submitting only few necessary functions for list operations.