From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:55294) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SDFEK-0003hH-1R for qemu-devel@nongnu.org; Thu, 29 Mar 2012 09:17:37 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1SDFED-0007kX-BI for qemu-devel@nongnu.org; Thu, 29 Mar 2012 09:17:31 -0400 Received: from mail-qc0-f173.google.com ([209.85.216.173]:62646) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SDFED-0007kH-4i for qemu-devel@nongnu.org; Thu, 29 Mar 2012 09:17:25 -0400 Received: by qcsc20 with SMTP id c20so1364692qcs.4 for ; Thu, 29 Mar 2012 06:17:23 -0700 (PDT) Sender: Richard Henderson Message-ID: <4F745F26.4090404@twiddle.net> Date: Thu, 29 Mar 2012 09:09:58 -0400 From: Richard Henderson MIME-Version: 1.0 References: <1332840290-24553-1-git-send-email-proljc@gmail.com> <1332840290-24553-7-git-send-email-proljc@gmail.com> <4F71E6AF.50506@twiddle.net> In-Reply-To: Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH V3 06/12] Add helper functions for MIPS DSP GPR-Based Shift instructions List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Jia Liu Cc: qemu-devel@nongnu.org, aurelien@aurel32.net On 03/27/2012 09:43 PM, Jia Liu wrote: > On Wed, Mar 28, 2012 at 12:11 AM, Richard Henderson wrote: >> On 03/27/12 02:24, Jia Liu wrote: >>> +DEF_HELPER_FLAGS_2(shll_qb, TCG_CALL_CONST | TCG_CALL_PURE, i32, int, i32) >> > > It should be DEF_HELPER_2(shll_qb, i32, int, i32). Is it? > Sorry I'm not sure about it. Exactly. r~