From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:42283) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SDF7N-0001DK-UE for qemu-devel@nongnu.org; Thu, 29 Mar 2012 09:10:27 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1SDF7L-0006C9-MG for qemu-devel@nongnu.org; Thu, 29 Mar 2012 09:10:21 -0400 Received: from cantor2.suse.de ([195.135.220.15]:58493 helo=mx2.suse.de) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SDF7L-0006Br-Cg for qemu-devel@nongnu.org; Thu, 29 Mar 2012 09:10:19 -0400 Message-ID: <4F745F39.2020006@suse.de> Date: Thu, 29 Mar 2012 15:10:17 +0200 From: =?ISO-8859-15?Q?Andreas_F=E4rber?= MIME-Version: 1.0 References: <1333024868-1336-1-git-send-email-atowers@gmail.com> In-Reply-To: <1333024868-1336-1-git-send-email-atowers@gmail.com> Content-Type: text/plain; charset=ISO-8859-15 Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH v2] ARM: Permit any ARMv6K CPU to read the MVFR0 and MVFR1 VFP registers. List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Andrew Towers Cc: Peter Maydell , qemu-devel@nongnu.org, Paul Brook Am 29.03.2012 14:41, schrieb Andrew Towers: > This patch replaces the ARM_FEATURE_VFP3 test when reading MVFR registe= rs > with a test for a new feature flag ARM_FEATURE_MVFR, and sets this feat= ure > for all ARMv6K cores (ARM1156 is not a v6K core, yet supports MVFR; qem= u > does not support ARM1156 at this time.) >=20 > MVFR0 and MVFR1 were introduced in ARM1136JF-S r1p0 (ARMv6K, VFPv2) and= are > present in ARM1156T2F-S (non-v6K), ARM1176JZF-S, ARM11MPCore and newer = cores. > Reference: ARM DDI 0211H, 0290G, 0301H, 0360E. > http://infocenter.arm.com/help/index.jsp?topic=3D/com.arm.doc.ddi0211h/= Ffbefjag.html >=20 > Without this change, the linux kernel will not boot with VFP support en= abled > under ARM1176 system emulation, due to the unconditional use of MVFR1 a= t the > end of vfp_init() in arch/arm/vfp/vfpmodule.c: >=20 > VFP support v0.3: implemetor 41 architecture 1 part 20 variant b rev = 5 > Internal error: Oops - undefined instruction: 0 [#1] >=20 > Signed-off-by: Andrew Towers Feature inference looks good, Reviewed-by: Andreas F=E4rber > --- >=20 > v2: > * introduced ARM_FEATURE_MVFR, implied by ARM_FEATURE_V6K. >=20 > Paul: I'd love to work on an rPi board model, and I'll see what I can p= ut > together, but much of the hardware is under NDA and I'm not in the loop= .. You might find the partial bcm2835 manual helpful: http://www.raspberrypi.org/archives/615 Open-source drivers (esp. Linux) are also often a helpful source for emulating NDA'ed hardware. Regards, Andreas --=20 SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 N=FCrnberg, Germany GF: Jeff Hawn, Jennifer Guild, Felix Imend=F6rffer; HRB 16746 AG N=FCrnbe= rg