From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([208.118.235.92]:40869)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <rth7680@gmail.com>) id 1SDFHS-0005TT-6i
	for qemu-devel@nongnu.org; Thu, 29 Mar 2012 09:20:51 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <rth7680@gmail.com>) id 1SDFHQ-0008RM-B7
	for qemu-devel@nongnu.org; Thu, 29 Mar 2012 09:20:45 -0400
Received: from mail-qa0-f52.google.com ([209.85.216.52]:53098)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <rth7680@gmail.com>) id 1SDFHQ-0008RE-3p
	for qemu-devel@nongnu.org; Thu, 29 Mar 2012 09:20:44 -0400
Received: by qabg40 with SMTP id g40so67083qab.4
	for <qemu-devel@nongnu.org>; Thu, 29 Mar 2012 06:20:42 -0700 (PDT)
Sender: Richard Henderson <rth7680@gmail.com>
Message-ID: <4F7461A5.50300@twiddle.net>
Date: Thu, 29 Mar 2012 09:20:37 -0400
From: Richard Henderson <rth@twiddle.net>
MIME-Version: 1.0
References: <1332840290-24553-1-git-send-email-proljc@gmail.com>
	<1332840290-24553-12-git-send-email-proljc@gmail.com>
	<4F71FD5C.809@twiddle.net>
	<CAJBMM-tb6TU=uEwPKaUZpB-xg9wAWO0q+-x9xy0vu0mWmvKEhg@mail.gmail.com>
In-Reply-To: <CAJBMM-tb6TU=uEwPKaUZpB-xg9wAWO0q+-x9xy0vu0mWmvKEhg@mail.gmail.com>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH V3 11/12] Handle MIPS DSP instructions in
 target-mips/translate.c
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Jia Liu <proljc@gmail.com>
Cc: qemu-devel@nongnu.org, aurelien@aurel32.net

On 03/27/2012 09:36 PM, Jia Liu wrote:
>> > This patch should have been split as well, adding translations of the insns
>> > at the same time you add the helpers.  That said, the actual code looks ok.
>> >
> helpers can be grouped by MIPS DSP manual, BUT translations have to
> grouped by opcode.
> There is some difference between them, I'll try to do this.
> 

One possibility is to add the bare skeleton of the decoding by opcode first,
leaving out the actual case statements.  Then add the

  case OPCODE:
    gen_helper();
    break;

in the patch adding the helpers.


r~