From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:54027) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SDJZW-0002uq-6T for qemu-devel@nongnu.org; Thu, 29 Mar 2012 13:55:43 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1SDJZQ-000495-TY for qemu-devel@nongnu.org; Thu, 29 Mar 2012 13:55:41 -0400 Received: from mx1.redhat.com ([209.132.183.28]:28950) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SDJZQ-00048u-Lq for qemu-devel@nongnu.org; Thu, 29 Mar 2012 13:55:36 -0400 Message-ID: <4F74A213.6030908@redhat.com> Date: Thu, 29 Mar 2012 11:55:31 -0600 From: Eric Blake MIME-Version: 1.0 References: <1333040202-11225-1-git-send-email-lcapitulino@redhat.com> <1333040202-11225-3-git-send-email-lcapitulino@redhat.com> In-Reply-To: <1333040202-11225-3-git-send-email-lcapitulino@redhat.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="------------enig773EB2CC0452BB03C6EC14D2" Subject: Re: [Qemu-devel] [PATCH 2/2] qapi: convert device_del List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Luiz Capitulino Cc: armbru@redhat.com, aliguori@us.ibm.com, qemu-devel@nongnu.org, stefanha@linux.vnet.ibm.com This is an OpenPGP/MIME signed message (RFC 2440 and 3156) --------------enig773EB2CC0452BB03C6EC14D2 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On 03/29/2012 10:56 AM, Luiz Capitulino wrote: > Signed-off-by: Anthony Liguori > Signed-off-by: Luiz Capitulino > --- > hmp-commands.hx | 3 +-- > hmp.c | 9 +++++++++ > hmp.h | 1 + > hw/qdev-monitor.c | 18 +++++------------- > qapi-schema.json | 20 ++++++++++++++++++++ > qmp-commands.hx | 5 +---- > 6 files changed, 37 insertions(+), 19 deletions(-) > +# @device_del: > +# > +# Remove a device from a guest > +# > +# @id: the name of the device > +# > +# Returns: Nothing on success > +# If @id is not a valid device, DeviceNotFound > +# If the device does not support unplug, BusNoHotplug > +# > +# Notes: When this command completes, the device may not be removed fr= om the > +# guest. Hot removal is an operation that requires guest coope= ration. > +# This command merely requests that the guest begin the hot rem= oval > +# process. Nothing against your patch itself, but is there any way we could enhance things in future patches to actually notify the management app when the guest has cooperated and the devices is actually removed? A new event would be helpful, as well as a way to detect whether the new event exists and should be waited for. --=20 Eric Blake eblake@redhat.com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --------------enig773EB2CC0452BB03C6EC14D2 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.12 (GNU/Linux) Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/ iQEcBAEBCAAGBQJPdKIUAAoJEKeha0olJ0NqIu4IAKQYm1Ferhi4aMqlHIKKQpXh rW2kVJ0JUKkvenNzTwWMSl9GgIGDIlm4kCEduiNJ8WvMm2+D1BahSofDxKcmNQm6 CGeIQ6FZHoNO0rDIbEXjq3F0ud5YrSL1TRyqaDDRimbmuhqkV6p3aiYq6E9HBrGZ 5B5eJDhtDB4TpgkhELQ0mc8ZxbRbCy48MkRwGf7RuHHIM/vvFHdMg7Wjm03KepZB 59Peb/wRrJv4lR6oLpbXsaqZYV/9mBmpKNqma7O2O8fCx/bzTKtiVWDtyCiHVwPn c3H0QlCo+DCbnMyF36sxFaUaBAeweB+u5xoxhEtrN/rcIPshUE7yAogglvNnh6k= =58Np -----END PGP SIGNATURE----- --------------enig773EB2CC0452BB03C6EC14D2--