From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:47765) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SDLoa-0006CF-Nv for qemu-devel@nongnu.org; Thu, 29 Mar 2012 16:19:26 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1SDLoY-0008O3-RW for qemu-devel@nongnu.org; Thu, 29 Mar 2012 16:19:24 -0400 Received: from mail-yx0-f173.google.com ([209.85.213.173]:56718) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SDLoY-0008Nt-NB for qemu-devel@nongnu.org; Thu, 29 Mar 2012 16:19:22 -0400 Received: by yenr5 with SMTP id r5so2234469yen.4 for ; Thu, 29 Mar 2012 13:19:20 -0700 (PDT) Message-ID: <4F74C3C4.5040608@codemonkey.ws> Date: Thu, 29 Mar 2012 15:19:16 -0500 From: Anthony Liguori MIME-Version: 1.0 References: <1332766053-9063-3-git-send-email-alevy@redhat.com> <1332771332-14090-1-git-send-email-alevy@redhat.com> In-Reply-To: <1332771332-14090-1-git-send-email-alevy@redhat.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH v2] spice_info: add mouse_mode List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Alon Levy Cc: qemu-devel@nongnu.org, kraxel@redhat.com On 03/26/2012 09:15 AM, Alon Levy wrote: > Add mouse_mode, either server or mouse, to qmp and hmp commands, based > on spice_server_is_server_mouse added in spice-server 0.10.3. > > Signed-off-by: Alon Levy > --- > v1->v2: > report mouse mode "unknown" for qmp too (Gerd Hoffman request) > > hmp.c | 1 + > qapi-schema.json | 7 ++++++- > ui/spice-core.c | 7 +++++++ > 3 files changed, 14 insertions(+), 1 deletion(-) > > diff --git a/hmp.c b/hmp.c > index 9cf2d13..8837dd0 100644 > --- a/hmp.c > +++ b/hmp.c > @@ -350,6 +350,7 @@ void hmp_info_spice(Monitor *mon) > } > monitor_printf(mon, " auth: %s\n", info->auth); > monitor_printf(mon, " compiled: %s\n", info->compiled_version); > + monitor_printf(mon, " mouse-mode: %s\n", info->mouse_mode); > > if (!info->has_channels || info->channels == NULL) { > monitor_printf(mon, "Channels: none\n"); > diff --git a/qapi-schema.json b/qapi-schema.json > index 0d11d6e..72c0080 100644 > --- a/qapi-schema.json > +++ b/qapi-schema.json > @@ -654,6 +654,11 @@ > # 'spice' uses SASL or direct TLS authentication, depending on command > # line options > # > +# @mouse-mode: #optional current server mouse mode if spice server is new > +# enough and exposes this information. > +# 'client' if client side > +# 'server' if server side > +# Please document which version this is being added in and use an enum instead of a string to describe the mode. If it's trouble a boolean, then use a bool instead of an enum. Regards, Anthony Liguori