From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:47237) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SDWdV-00066X-1k for qemu-devel@nongnu.org; Fri, 30 Mar 2012 03:52:42 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1SDWdO-00050W-Qv for qemu-devel@nongnu.org; Fri, 30 Mar 2012 03:52:40 -0400 Received: from mx1.redhat.com ([209.132.183.28]:46704) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SDWdO-00050E-J7 for qemu-devel@nongnu.org; Fri, 30 Mar 2012 03:52:34 -0400 Received: from int-mx10.intmail.prod.int.phx2.redhat.com (int-mx10.intmail.prod.int.phx2.redhat.com [10.5.11.23]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id q2U7qXjE015028 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Fri, 30 Mar 2012 03:52:33 -0400 Message-ID: <4F7566BE.1040605@redhat.com> Date: Fri, 30 Mar 2012 09:54:38 +0200 From: Hans de Goede MIME-Version: 1.0 References: <1333032538-3919-1-git-send-email-kraxel@redhat.com> In-Reply-To: <1333032538-3919-1-git-send-email-kraxel@redhat.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 0/6] usb: descriptor rework. List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Gerd Hoffmann Cc: qemu-devel@nongnu.org Looks good, ack series. Acked-by: Hans de Goede On 03/29/2012 04:48 PM, Gerd Hoffmann wrote: > Hi, > > This patch series reworks the usb descriptor handling in qemu. It adds > a struct for the binary representation of usb descriptors. It is put > into use for both generating usb descriptors (for emulated devices) and > parsing usb descriptors (usb-host driver). Additionally the usb-host > parser code has been completely rewritten to simplify the logic and to > make it more robust. > > please review, > Gerd > > Gerd Hoffmann (6): > usb: add USBDescriptor, use for device descriptors. > usb: use USBDescriptor for device qualifier descriptors. > usb: use USBDescriptor for config descriptors. > usb: use USBDescriptor for interface descriptors. > usb: use USBDescriptor for endpoint descriptors. > usb-host: rewrite usb_linux_update_endp_table > > hw/usb/desc.c | 126 ++++++++++++++++++---------------- > hw/usb/desc.h | 63 +++++++++++++++++ > hw/usb/host-linux.c | 194 ++++++++++++++++++++++++++------------------------ > trace-events | 6 ++ > 4 files changed, 237 insertions(+), 152 deletions(-) > >