From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:50695) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SDWu4-00054h-7u for qemu-devel@nongnu.org; Fri, 30 Mar 2012 04:09:49 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1SDWu2-0001hG-Fw for qemu-devel@nongnu.org; Fri, 30 Mar 2012 04:09:47 -0400 Received: from mx1.redhat.com ([209.132.183.28]:57292) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SDWu2-0001gn-7w for qemu-devel@nongnu.org; Fri, 30 Mar 2012 04:09:46 -0400 Received: from int-mx01.intmail.prod.int.phx2.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id q2U89iIN002955 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Fri, 30 Mar 2012 04:09:44 -0400 Message-ID: <4F756A46.50102@redhat.com> Date: Fri, 30 Mar 2012 10:09:42 +0200 From: Gerd Hoffmann MIME-Version: 1.0 References: <1333054606-19847-1-git-send-email-alevy@redhat.com> In-Reply-To: <1333054606-19847-1-git-send-email-alevy@redhat.com> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [RFC] qxl: don't panic on phys2virt List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Alon Levy Cc: qemu-devel@nongnu.org On 03/29/12 22:56, Alon Levy wrote: > Issues a qxl_guest_bug from qxl_phys2virt. Everywhere else will fail. Nice start (there are more guest-triggerable asserts to be fixed this way). > qxl_phys2virt requires an additional argument because all it's possible > return values are legit (well, I could use the fact it returns a pointer > so it should be word aligned but I don't want to go there, this is > totally internal). Really? What is bad with returning and checking for NULL? Guest memslots are backed by guest ram and should never ever resolve to a NULL pointer in qemu's process address space. cheers, Gerd