From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:60185) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SDYCV-0003La-SU for qemu-devel@nongnu.org; Fri, 30 Mar 2012 05:33:02 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1SDYCT-0003zo-Rb for qemu-devel@nongnu.org; Fri, 30 Mar 2012 05:32:55 -0400 Received: from cantor2.suse.de ([195.135.220.15]:41793 helo=mx2.suse.de) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SDYCT-0003zU-Gy for qemu-devel@nongnu.org; Fri, 30 Mar 2012 05:32:53 -0400 Message-ID: <4F757DBD.9090206@suse.de> Date: Fri, 30 Mar 2012 11:32:45 +0200 From: =?ISO-8859-15?Q?Andreas_F=E4rber?= MIME-Version: 1.0 References: <1332816201-5072-1-git-send-email-david@gibson.dropbear.id.au> In-Reply-To: <1332816201-5072-1-git-send-email-david@gibson.dropbear.id.au> Content-Type: text/plain; charset=ISO-8859-15 Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH] Better support for dma_addr_t variables List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: David Gibson Cc: aliguori@us.ibm.com, qemu-devel@nongnu.org, mst@redhat.com Am 27.03.2012 04:43, schrieb David Gibson: > A while back, we introduced the dma_addr_t type, which is supposed to > be used for bus visible memory addresses. At present, this is an > alias for target_phys_addr_t, but this will change when we eventually > add support for guest visible IOMMUs. >=20 > There are some instances of target_phys_addr_t in the code now which > should really be dma_addr_t, but can't be trivially converted due to > missing features which this patch corrects. >=20 > * We add DMA_ADDR_BITS analagous to TARGET_PHYS_ADDR_BITS. This is > important where we need to make a compile-time (#if) based on the > size of dma_addr_t. >=20 > * We add a new helper macro to create device properties which take a > dma_addr_t, currently an alias to DEFINE_PROP_TADDR(). >=20 > Signed-off-by: David Gibson > --- > dma.h | 1 + > hw/qdev-dma.h | 4 ++++ > 2 files changed, 5 insertions(+), 0 deletions(-) > create mode 100644 hw/qdev-dma.h >=20 > diff --git a/dma.h b/dma.h > index 05ac325..463095c 100644 > --- a/dma.h > +++ b/dma.h > @@ -32,6 +32,7 @@ struct QEMUSGList { > #if defined(TARGET_PHYS_ADDR_BITS) > typedef target_phys_addr_t dma_addr_t; > =20 > +#define DMA_ADDR_BITS TARGET_PHYS_ADDR_BITS > #define DMA_ADDR_FMT TARGET_FMT_plx > =20 > struct ScatterGatherEntry { > diff --git a/hw/qdev-dma.h b/hw/qdev-dma.h > new file mode 100644 > index 0000000..e407771 > --- /dev/null > +++ b/hw/qdev-dma.h > @@ -0,0 +1,4 @@ > +#include "qdev-addr.h" > + > +#define DEFINE_PROP_DMAADDR(_n, _s, _f, _d) = \ > + DEFINE_PROP_TADDR(_n, _s, _f, _d) Is a new header just for this really needed? It's not being used in this patch, so its necessity is hard to judge. ;) I would've expected DEFINE_PROP_... in qdev.h along the others. Andreas --=20 SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 N=FCrnberg, Germany GF: Jeff Hawn, Jennifer Guild, Felix Imend=F6rffer; HRB 16746 AG N=FCrnbe= rg