qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Paolo Bonzini <pbonzini@redhat.com>
Cc: kwolf@redhat.com, Stefan Hajnoczi <stefanha@gmail.com>,
	qemu-devel@nongnu.org, stefanha@linux.vnet.ibm.com
Subject: Re: [Qemu-devel] [PATCH] block: fix streaming/closing race
Date: Fri, 30 Mar 2012 12:00:48 +0200	[thread overview]
Message-ID: <4F758450.2080001@redhat.com> (raw)
In-Reply-To: <4F756F51.5010603@redhat.com>

Il 30/03/2012 10:31, Paolo Bonzini ha scritto:
> However, even this is not enough.  It fixes a race with closing, but not
> with deleting bs.  So the bug does not show anymore when you quit QEMU
> (because the coroutine is not restarted), but it is still there if you
> hot-unplug a device while streaming is in effect.

Nevermind, hot-unplug is handled by the reference counting mechanism; so
this patch is enough.  However, we may still want to cancel the job when
a device is hot-unplugged.  I'll resubmit this patch as a series and
with a better commit message.

Paolo

  reply	other threads:[~2012-03-30 10:01 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-03-29 16:08 [Qemu-devel] [PATCH] block: fix streaming/closing race Paolo Bonzini
2012-03-30  7:19 ` Stefan Hajnoczi
2012-03-30  8:31   ` Paolo Bonzini
2012-03-30 10:00     ` Paolo Bonzini [this message]
2012-03-30 10:25     ` Stefan Hajnoczi
2012-03-30 10:29       ` Paolo Bonzini

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4F758450.2080001@redhat.com \
    --to=pbonzini@redhat.com \
    --cc=kwolf@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=stefanha@gmail.com \
    --cc=stefanha@linux.vnet.ibm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).