From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:32873) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SDYdk-0002Os-Cp for qemu-devel@nongnu.org; Fri, 30 Mar 2012 06:01:08 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1SDYdd-0002mA-Vd for qemu-devel@nongnu.org; Fri, 30 Mar 2012 06:01:03 -0400 Received: from mail-pb0-f45.google.com ([209.85.160.45]:38562) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SDYdd-0002ll-MW for qemu-devel@nongnu.org; Fri, 30 Mar 2012 06:00:57 -0400 Received: by pbcuo5 with SMTP id uo5so1724126pbc.4 for ; Fri, 30 Mar 2012 03:00:55 -0700 (PDT) Sender: Paolo Bonzini Message-ID: <4F758450.2080001@redhat.com> Date: Fri, 30 Mar 2012 12:00:48 +0200 From: Paolo Bonzini MIME-Version: 1.0 References: <1333037320-20564-1-git-send-email-pbonzini@redhat.com> <20120330071921.GB16159@stefanha-thinkpad.localdomain> <4F756F51.5010603@redhat.com> In-Reply-To: <4F756F51.5010603@redhat.com> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH] block: fix streaming/closing race List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: kwolf@redhat.com, Stefan Hajnoczi , qemu-devel@nongnu.org, stefanha@linux.vnet.ibm.com Il 30/03/2012 10:31, Paolo Bonzini ha scritto: > However, even this is not enough. It fixes a race with closing, but not > with deleting bs. So the bug does not show anymore when you quit QEMU > (because the coroutine is not restarted), but it is still there if you > hot-unplug a device while streaming is in effect. Nevermind, hot-unplug is handled by the reference counting mechanism; so this patch is enough. However, we may still want to cancel the job when a device is hot-unplugged. I'll resubmit this patch as a series and with a better commit message. Paolo