From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([208.118.235.92]:54625)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <rth7680@gmail.com>) id 1SDZ9O-0008Tx-Mb
	for qemu-devel@nongnu.org; Fri, 30 Mar 2012 06:33:50 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <rth7680@gmail.com>) id 1SDZ9I-0005fa-Hz
	for qemu-devel@nongnu.org; Fri, 30 Mar 2012 06:33:46 -0400
Received: from mail-gx0-f173.google.com ([209.85.161.173]:47424)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <rth7680@gmail.com>) id 1SDZ9I-0005fJ-BT
	for qemu-devel@nongnu.org; Fri, 30 Mar 2012 06:33:40 -0400
Received: by ggnp2 with SMTP id p2so257520ggn.4
	for <qemu-devel@nongnu.org>; Fri, 30 Mar 2012 03:33:38 -0700 (PDT)
Sender: Richard Henderson <rth7680@gmail.com>
Message-ID: <4F758BFC.7080804@twiddle.net>
Date: Fri, 30 Mar 2012 06:33:32 -0400
From: Richard Henderson <rth@twiddle.net>
MIME-Version: 1.0
References: <1333077432-22228-1-git-send-email-proljc@gmail.com>
	<1333077432-22228-5-git-send-email-proljc@gmail.com>
In-Reply-To: <1333077432-22228-5-git-send-email-proljc@gmail.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH V4 04/11] Add MIPS DSP Load instructions
	Support
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Jia Liu <proljc@gmail.com>
Cc: qemu-devel@nongnu.org, aurelien@aurel32.net

On 03/29/2012 11:17 PM, Jia Liu wrote:
> +                    save_cpu_state(ctx, 1);
> +                    gen_op_addr_add(ctx, addr, cpu_gpr[rs], cpu_gpr[rt]);
> +                    op_ld_lh(cpu_gpr[rd], addr, ctx);

You should't need to save pc state in these; this should be
comparable to 

>     case OPC_LB:
>         save_cpu_state(ctx, 0);
>         op_ld_lb(t0, t0, ctx);
>         gen_store_gpr(t0, rt);


r~