From: Anthony Liguori <anthony@codemonkey.ws>
To: Wanpeng Li <liwp@linux.vnet.ibm.com>
Cc: "Gavin Shan" <shangw@linux.vnet.ibm.com>,
"Stefan Hajnoczi" <stefanha@gmail.com>,
"Anthony Liguori" <aliguori@us.ibm.com>,
"Andreas Färber" <afaerber@suse.de>,
qemu-devel <qemu-devel@nongnu.org>
Subject: Re: [Qemu-devel] [PATCH] RFC: options parse in vl.c should be moduled
Date: Fri, 30 Mar 2012 08:10:17 -0500 [thread overview]
Message-ID: <4F75B0B9.7090303@codemonkey.ws> (raw)
In-Reply-To: <1333111003-28556-1-git-send-email-liwp@linux.vnet.ibm.com>
On 03/30/2012 07:36 AM, Wanpeng Li wrote:
> Consider of the options parse process in main function of vl.c is too
> long.It should be module into single function to clear ideas, strengthen
> the source code management, and increase code readability.So I module the
> process of options parse as function options_parse, and expose some variables
> in order to not influence command-line invocations.
>
> Signed-off-by: Wanpeng Li<liwp@linux.vnet.ibm.com>
I've got pending patches that significantly refactor this code.
http://mid.gmane.org/1332169763-30665-1-git-send-email-aliguori@us.ibm.com
I think I'll drop some of the more controversial patches and resubmit soon.
Regards,
Anthony Liguori
next prev parent reply other threads:[~2012-03-30 13:10 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-03-30 12:36 [Qemu-devel] [PATCH] RFC: options parse in vl.c should be moduled Wanpeng Li
2012-03-30 12:53 ` Daniel P. Berrange
2012-03-30 13:25 ` Wanpeng Li
[not found] ` <4f75b5f3.2235b60a.302d.ffffa586SMTPIN_ADDED@mx.google.com>
2012-03-30 15:55 ` Michael Roth
2012-03-30 13:10 ` Anthony Liguori [this message]
2012-03-30 15:59 ` Lluís Vilanova
2012-03-30 16:09 ` Anthony Liguori
2012-03-30 16:31 ` Anthony Liguori
2012-03-30 17:52 ` Lluís Vilanova
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4F75B0B9.7090303@codemonkey.ws \
--to=anthony@codemonkey.ws \
--cc=afaerber@suse.de \
--cc=aliguori@us.ibm.com \
--cc=liwp@linux.vnet.ibm.com \
--cc=qemu-devel@nongnu.org \
--cc=shangw@linux.vnet.ibm.com \
--cc=stefanha@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).