From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:45461) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SDbb3-00057b-DT for qemu-devel@nongnu.org; Fri, 30 Mar 2012 09:10:35 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1SDbax-0005AA-4D for qemu-devel@nongnu.org; Fri, 30 Mar 2012 09:10:28 -0400 Received: from mail-ob0-f173.google.com ([209.85.214.173]:46644) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SDbaw-00059t-VA for qemu-devel@nongnu.org; Fri, 30 Mar 2012 09:10:23 -0400 Received: by obbwd20 with SMTP id wd20so1067811obb.4 for ; Fri, 30 Mar 2012 06:10:21 -0700 (PDT) Message-ID: <4F75B0B9.7090303@codemonkey.ws> Date: Fri, 30 Mar 2012 08:10:17 -0500 From: Anthony Liguori MIME-Version: 1.0 References: <1333111003-28556-1-git-send-email-liwp@linux.vnet.ibm.com> In-Reply-To: <1333111003-28556-1-git-send-email-liwp@linux.vnet.ibm.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH] RFC: options parse in vl.c should be moduled List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Wanpeng Li Cc: Gavin Shan , Stefan Hajnoczi , Anthony Liguori , =?ISO-8859-1?Q?Andreas_F=E4rber?= , qemu-devel On 03/30/2012 07:36 AM, Wanpeng Li wrote: > Consider of the options parse process in main function of vl.c is too > long.It should be module into single function to clear ideas, strengthen > the source code management, and increase code readability.So I module the > process of options parse as function options_parse, and expose some variables > in order to not influence command-line invocations. > > Signed-off-by: Wanpeng Li I've got pending patches that significantly refactor this code. http://mid.gmane.org/1332169763-30665-1-git-send-email-aliguori@us.ibm.com I think I'll drop some of the more controversial patches and resubmit soon. Regards, Anthony Liguori