From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([208.118.235.92]:38630)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <hdegoede@redhat.com>) id 1SDcfV-00029M-8z
	for qemu-devel@nongnu.org; Fri, 30 Mar 2012 10:19:15 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <hdegoede@redhat.com>) id 1SDcfP-0005RW-Rr
	for qemu-devel@nongnu.org; Fri, 30 Mar 2012 10:19:08 -0400
Received: from mx1.redhat.com ([209.132.183.28]:4388)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <hdegoede@redhat.com>) id 1SDcfP-0005RC-J6
	for qemu-devel@nongnu.org; Fri, 30 Mar 2012 10:19:03 -0400
Received: from int-mx09.intmail.prod.int.phx2.redhat.com
	(int-mx09.intmail.prod.int.phx2.redhat.com [10.5.11.22])
	by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id q2UEJ2Eg021455
	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK)
	for <qemu-devel@nongnu.org>; Fri, 30 Mar 2012 10:19:02 -0400
Message-ID: <4F75C153.6030908@redhat.com>
Date: Fri, 30 Mar 2012 16:21:07 +0200
From: Hans de Goede <hdegoede@redhat.com>
MIME-Version: 1.0
References: <1333106781-12978-1-git-send-email-kraxel@redhat.com>
In-Reply-To: <1333106781-12978-1-git-send-email-kraxel@redhat.com>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH] usb-ehci: drop assert()
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Gerd Hoffmann <kraxel@redhat.com>
Cc: qemu-devel@nongnu.org

Looks good, ACK.

Acked-by: Hans de Goede <hdegoede@redhat.com>


On 03/30/2012 01:26 PM, Gerd Hoffmann wrote:
> Not sure what the purpose of the assert() was, in any case it is bogous.
> We can arrive there if transfer descriptors passed to us from the guest
> failed to pass sanity checks, i.e. it is guest-triggerable.  We deal
> with that case by resetting the host controller.  Everything is ok, no
> need to throw a core dump here.
>
> Signed-off-by: Gerd Hoffmann<kraxel@redhat.com>
> ---
>   hw/usb/hcd-ehci.c |    1 -
>   1 files changed, 0 insertions(+), 1 deletions(-)
>
> diff --git a/hw/usb/hcd-ehci.c b/hw/usb/hcd-ehci.c
> index e12f098..23631a4 100644
> --- a/hw/usb/hcd-ehci.c
> +++ b/hw/usb/hcd-ehci.c
> @@ -2009,7 +2009,6 @@ static void ehci_advance_state(EHCIState *ehci,
>               fprintf(stderr, "processing error - resetting ehci HC\n");
>               ehci_reset(ehci);
>               again = 0;
> -            assert(0);
>           }
>       }
>       while (again);