From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:47433) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SDhUK-00043f-Ti for qemu-devel@nongnu.org; Fri, 30 Mar 2012 15:27:58 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1SDhUI-0008Mw-Rg for qemu-devel@nongnu.org; Fri, 30 Mar 2012 15:27:56 -0400 Received: from mail-ob0-f173.google.com ([209.85.214.173]:53898) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SDhUI-0008Mi-Mp for qemu-devel@nongnu.org; Fri, 30 Mar 2012 15:27:54 -0400 Received: by obbwd20 with SMTP id wd20so1517308obb.4 for ; Fri, 30 Mar 2012 12:27:53 -0700 (PDT) Message-ID: <4F760936.90709@codemonkey.ws> Date: Fri, 30 Mar 2012 14:27:50 -0500 From: Anthony Liguori MIME-Version: 1.0 References: <1333130099-25238-1-git-send-email-aliguori@us.ibm.com> <4F75F468.7010804@codemonkey.ws> <4F75F564.7040602@mail.berlios.de> <4F75FB78.4090501@codemonkey.ws> <4F76018A.308@redhat.com> <4F76042A.8040007@codemonkey.ws> <4F7605E9.4060608@redhat.com> <4F760697.7060304@codemonkey.ws> <4F760819.60409@mail.berlios.de> In-Reply-To: <4F760819.60409@mail.berlios.de> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH] qtest: fix 32-bit build List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Stefan Weil Cc: Paolo Bonzini , qemu-devel@nongnu.org On 03/30/2012 02:23 PM, Stefan Weil wrote: > Am 30.03.2012 21:16, schrieb Anthony Liguori: >> On 03/30/2012 02:13 PM, Paolo Bonzini wrote: >>> Il 30/03/2012 21:06, Anthony Liguori ha scritto: >>>> On 03/30/2012 01:55 PM, Paolo Bonzini wrote: >>>>> Il 30/03/2012 20:29, Anthony Liguori ha scritto: >>>>>>> Now it will fail with w64 (which uses 64 bit time_t and >>>>>>> a 32 bit long). >>>>>> >>>>>> That's a bug in w64 (it has a broken ABI). >>>>>> >>>>>> Do we actually build and run on w64?? >>>>> >>>>> It's actually sensible and x32 does the same. Not too urgent though. >>>> >>>> I don't understand how making a long 32 bit is sensible but... I sent a >>>> patch that should at least address q64. >>>> >>>> Am not sure what x32 is though. >>> >>> x32 is 32-bit ABI (with 32-bit pointers and 4GB address space) with the >>> x86-64 (64-bit) ISA. >> >> Wow. That's.. interesting :-) >> >> In general, violating sizeof(long) >= sizeof(void *) seems like an exceeding >> bad idea to me. >> >> Regards, >> >> Anthony Liguori > > Any 32 bit system will have to use a 64 bit time_t sooner or later > to avoid an overflow. Not only w64 but also w32 supports it. > Future 32 bit Linux versions will also need it. > > The size of a long is a different matter. Yet another reason that we all should build bunkers for the upcoming Unix epoch overflow apocalypse.. that is, if the machines don't revolt before 2038 ;-) Regards, Anthony Liguori > Regards, > Stefan W. >