From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([208.118.235.92]:44463)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <afaerber@suse.de>) id 1SE1MT-0005Be-Oh
	for qemu-devel@nongnu.org; Sat, 31 Mar 2012 12:41:11 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <afaerber@suse.de>) id 1SE1MR-0005Fw-RM
	for qemu-devel@nongnu.org; Sat, 31 Mar 2012 12:41:09 -0400
Received: from cantor2.suse.de ([195.135.220.15]:51576 helo=mx2.suse.de)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <afaerber@suse.de>) id 1SE1MR-0005Fg-Ko
	for qemu-devel@nongnu.org; Sat, 31 Mar 2012 12:41:07 -0400
Message-ID: <4F772590.2000603@suse.de>
Date: Sat, 31 Mar 2012 17:41:04 +0200
From: =?UTF-8?B?QW5kcmVhcyBGw6RyYmVy?= <afaerber@suse.de>
MIME-Version: 1.0
References: <20120330152436.GA31016@aepfle.de>
In-Reply-To: <20120330152436.GA31016@aepfle.de>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
Subject: Re: [Qemu-devel] [PATCH] qemu/configure: fix CFLAGS handling for
 i386
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Olaf Hering <olaf@aepfle.de>
Cc: xen-devel@lists.xensource.com, Erik Blake <eblake@redhat.com>, qemu-devel@nongnu.org

Hi Olaf,

Am 30.03.2012 17:24, schrieb Olaf Hering:
>=20
> configure will generate incorrect CFLAGS which will lead to compile
> errors due to unknown gcc options, IFF CFLAGS was already in the
> environment during configure invocation.
>=20
> Add a space before the -march=3Di486 gcc option.
>=20
> This patch is against the qemu-xen tree, but it should apply also to
> qemu.git since it has the same issue. Please apply to both trees.
>=20
> Signed-off-by: Olaf Hering <olaf@aepfle.de>

The patch applies fine to upstream QEMU (we should strip leading qemu/
from the commit message though).

This is the only usage of +=3D outside Makefile fragments, so I wonder if
its use may have been by accident. Is it safe in a POSIX context?
Or should we better use CFLAGS=3D"$CFLAGS -march=3D486"?
For QEMU_CFLAGS we use the pattern QEMU_CFLAGS=3D"-options $QEMU_CFLAGS"
to allow overriding options.

Andreas

>=20
> ---
>  configure |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>=20
> Index: qemu-xen-dir-remote/configure
> =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D
> --- qemu-xen-dir-remote.orig/configure
> +++ qemu-xen-dir-remote/configure
> @@ -2637,7 +2637,7 @@ int main(int argc, char **argv)
>  }
>  EOF
>    if ! compile_prog "" "" ; then
> -    CFLAGS+=3D"-march=3Di486"
> +    CFLAGS+=3D" -march=3Di486"
>    fi
>  fi
> =20

--=20
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 N=C3=BCrnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imend=C3=B6rffer; HRB 16746 AG N=C3=BC=
rnberg