From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:53967) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SEGHc-0004pO-LC for qemu-devel@nongnu.org; Sun, 01 Apr 2012 04:37:10 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1SEGHa-0002kg-LI for qemu-devel@nongnu.org; Sun, 01 Apr 2012 04:37:08 -0400 Received: from fmmailgate06.web.de ([217.72.192.247]:51074) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SEGHa-0002j3-Br for qemu-devel@nongnu.org; Sun, 01 Apr 2012 04:37:06 -0400 Received: from moweb002.kundenserver.de (moweb002.kundenserver.de [172.19.20.108]) by fmmailgate06.web.de (Postfix) with ESMTP id E70C01074406 for ; Sun, 1 Apr 2012 10:37:03 +0200 (CEST) Message-ID: <4F7813AB.5000802@web.de> Date: Sun, 01 Apr 2012 10:36:59 +0200 From: Jan Kiszka MIME-Version: 1.0 References: <20120401024817.GA14275@rox.home.comstyle.com> In-Reply-To: <20120401024817.GA14275@rox.home.comstyle.com> Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="------------enigF5AF9618E325D996FFC069FE" Subject: Re: [Qemu-devel] More build breakage: signrom.sh vs kvmvapic.bin List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Brad Smith Cc: Anthony Liguori , qemu-devel@nongnu.org This is an OpenPGP/MIME signed message (RFC 2440 and 3156) --------------enigF5AF9618E325D996FFC069FE Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable On 2012-04-01 04:48, Brad Smith wrote: > Here is another source of build breakage that popped up over a month ag= o. >=20 > The patch below fixes the build but I'm wondering why the file in quest= ion > is being built on anything but Linux. It seems to be used for KVM suppo= rt > and thus has no relevance on any other OS. It is only build on x86 unix hosts minus Mac. We are shipping it as binary for the rest. There is WIP on getting KVM working for Solaris, so this may not be of Linux-only interest in the future. >=20 >=20 > AS optionrom/kvmvapic.o > Building optionrom/kvmvapic.img > Building optionrom/kvmvapic.raw > Signing optionrom/kvmvapic.bin > /buildbot-qemu/default_openbsd_current/build/scripts/signrom.sh[31]: = 018 *= 512 - 1 : bad number `018' > gmake[1]: *** [kvmvapic.bin] Error 1 >=20 >=20 > diff --git a/scripts/signrom.sh b/scripts/signrom.sh > index 9dc5c63..2d421e9 100755 > --- a/scripts/signrom.sh > +++ b/scripts/signrom.sh > @@ -27,8 +27,8 @@ sum=3D0 > =20 > # find out the file size > x=3D`dd if=3D"$1" bs=3D1 count=3D1 skip=3D2 2>/dev/null | od -t u1 -A = n` > -#size=3D`expr $x \* 512 - 1` > -size=3D$(( $x * 512 - 1 )) > +size=3D`expr $x \* 512 - 1` > +#size=3D$(( $x * 512 - 1 )) > =20 > # now get the checksum > nums=3D`od -A n -t u1 -v -N $size "$1"` >=20 signrom.sh is horribly slow and should be replaced soon, see http://thread.gmane.org/gmane.comp.emulators.qemu/139368 Jan --------------enigF5AF9618E325D996FFC069FE Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.16 (GNU/Linux) Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/ iEYEARECAAYFAk94E64ACgkQitSsb3rl5xRyswCglnleYVfszkIBLUXW69PDEfpd lIUAn08T8bqPPUq8uhkuQX2WS+w6bSll =P9bX -----END PGP SIGNATURE----- --------------enigF5AF9618E325D996FFC069FE--