* [Qemu-devel] [PATCH] use: fix bit test
@ 2012-04-02 6:35 Lai Jiangshan
2012-04-02 9:50 ` Andreas Färber
0 siblings, 1 reply; 3+ messages in thread
From: Lai Jiangshan @ 2012-04-02 6:35 UTC (permalink / raw)
To: Gerd Hoffmann, qemu-devel@nongnu.org
use & instead of the wrong &&
Signed-off-by: Lai Jiangshan <laijs@cn.fujitsu.com>
---
diff --git a/hw/usb/hcd-xhci.c b/hw/usb/hcd-xhci.c
index 73b0c7f..89c2406 100644
--- a/hw/usb/hcd-xhci.c
+++ b/hw/usb/hcd-xhci.c
@@ -502,7 +502,7 @@ static void xhci_irq_update(XHCIState *xhci)
int level = 0;
if (xhci->iman & IMAN_IP && xhci->iman & IMAN_IE &&
- xhci->usbcmd && USBCMD_INTE) {
+ xhci->usbcmd & USBCMD_INTE) {
level = 1;
}
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [Qemu-devel] [PATCH] use: fix bit test
2012-04-02 6:35 [Qemu-devel] [PATCH] use: fix bit test Lai Jiangshan
@ 2012-04-02 9:50 ` Andreas Färber
2012-04-03 2:52 ` Lai Jiangshan
0 siblings, 1 reply; 3+ messages in thread
From: Andreas Färber @ 2012-04-02 9:50 UTC (permalink / raw)
To: Lai Jiangshan, Gerd Hoffmann; +Cc: qemu-devel@nongnu.org
Am 02.04.2012 08:35, schrieb Lai Jiangshan:
>
> use & instead of the wrong &&
>
> Signed-off-by: Lai Jiangshan <laijs@cn.fujitsu.com>
Patch looks okay but the subject should probably be fixed to say "usb:"
when applying. :)
Andreas
> ---
> diff --git a/hw/usb/hcd-xhci.c b/hw/usb/hcd-xhci.c
> index 73b0c7f..89c2406 100644
> --- a/hw/usb/hcd-xhci.c
> +++ b/hw/usb/hcd-xhci.c
> @@ -502,7 +502,7 @@ static void xhci_irq_update(XHCIState *xhci)
> int level = 0;
>
> if (xhci->iman & IMAN_IP && xhci->iman & IMAN_IE &&
> - xhci->usbcmd && USBCMD_INTE) {
> + xhci->usbcmd & USBCMD_INTE) {
> level = 1;
> }
>
--
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 16746 AG Nürnberg
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [Qemu-devel] [PATCH] use: fix bit test
2012-04-02 9:50 ` Andreas Färber
@ 2012-04-03 2:52 ` Lai Jiangshan
0 siblings, 0 replies; 3+ messages in thread
From: Lai Jiangshan @ 2012-04-03 2:52 UTC (permalink / raw)
To: Gerd Hoffmann; +Cc: Andreas Färber, qemu-devel@nongnu.org
On 04/02/2012 05:50 PM, Andreas Färber wrote:
> Am 02.04.2012 08:35, schrieb Lai Jiangshan:
>>
>> use & instead of the wrong &&
>>
>> Signed-off-by: Lai Jiangshan <laijs@cn.fujitsu.com>
>
> Patch looks okay but the subject should probably be fixed to say "usb:"
> when applying. :)
>
Thank you!!
Hi, Gerd,
Does this patch have any problem?
could you merge it with "use:"->"usb:" in the title.
(I think it is not good to send another patch for this)
Thanks
Lai
>
>> ---
>> diff --git a/hw/usb/hcd-xhci.c b/hw/usb/hcd-xhci.c
>> index 73b0c7f..89c2406 100644
>> --- a/hw/usb/hcd-xhci.c
>> +++ b/hw/usb/hcd-xhci.c
>> @@ -502,7 +502,7 @@ static void xhci_irq_update(XHCIState *xhci)
>> int level = 0;
>>
>> if (xhci->iman & IMAN_IP && xhci->iman & IMAN_IE &&
>> - xhci->usbcmd && USBCMD_INTE) {
>> + xhci->usbcmd & USBCMD_INTE) {
>> level = 1;
>> }
>>
>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2012-04-03 2:47 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-04-02 6:35 [Qemu-devel] [PATCH] use: fix bit test Lai Jiangshan
2012-04-02 9:50 ` Andreas Färber
2012-04-03 2:52 ` Lai Jiangshan
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).