From: "Andreas Färber" <afaerber@suse.de>
To: Olaf Hering <olaf@aepfle.de>
Cc: xen-devel@lists.xensource.com, Erik Blake <eblake@redhat.com>,
qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH] qemu/configure: fix CFLAGS handling for i386
Date: Mon, 02 Apr 2012 09:54:58 +0200 [thread overview]
Message-ID: <4F795B52.9060803@suse.de> (raw)
In-Reply-To: <20120331164627.GA23873@aepfle.de>
Am 31.03.2012 18:46, schrieb Olaf Hering:
> On Sat, Mar 31, Andreas Färber wrote:
>
>> This is the only usage of += outside Makefile fragments, so I wonder if
>> its use may have been by accident. Is it safe in a POSIX context?
>> Or should we better use CFLAGS="$CFLAGS -march=486"?
>
> Now that I look at the shebang, configure is a sh script and += is most
> likely a bash feature. So your suggestion for the assignment is correct.
...apart from the missing i in i486, obviously. ;)
Andreas
--
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 16746 AG Nürnberg
next prev parent reply other threads:[~2012-04-02 7:55 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-03-30 15:24 [Qemu-devel] [PATCH] qemu/configure: fix CFLAGS handling for i386 Olaf Hering
2012-03-31 15:41 ` Andreas Färber
2012-03-31 16:46 ` Olaf Hering
2012-04-02 7:54 ` Andreas Färber [this message]
2012-03-31 16:52 ` Peter Maydell
2012-03-31 16:55 ` Olaf Hering
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4F795B52.9060803@suse.de \
--to=afaerber@suse.de \
--cc=eblake@redhat.com \
--cc=olaf@aepfle.de \
--cc=qemu-devel@nongnu.org \
--cc=xen-devel@lists.xensource.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).