From: "Andreas Färber" <afaerber@suse.de>
To: Lai Jiangshan <laijs@cn.fujitsu.com>, Gerd Hoffmann <kraxel@redhat.com>
Cc: "qemu-devel@nongnu.org" <qemu-devel@nongnu.org>
Subject: Re: [Qemu-devel] [PATCH] use: fix bit test
Date: Mon, 02 Apr 2012 11:50:24 +0200 [thread overview]
Message-ID: <4F797660.4070907@suse.de> (raw)
In-Reply-To: <4F7948B2.4090100@cn.fujitsu.com>
Am 02.04.2012 08:35, schrieb Lai Jiangshan:
>
> use & instead of the wrong &&
>
> Signed-off-by: Lai Jiangshan <laijs@cn.fujitsu.com>
Patch looks okay but the subject should probably be fixed to say "usb:"
when applying. :)
Andreas
> ---
> diff --git a/hw/usb/hcd-xhci.c b/hw/usb/hcd-xhci.c
> index 73b0c7f..89c2406 100644
> --- a/hw/usb/hcd-xhci.c
> +++ b/hw/usb/hcd-xhci.c
> @@ -502,7 +502,7 @@ static void xhci_irq_update(XHCIState *xhci)
> int level = 0;
>
> if (xhci->iman & IMAN_IP && xhci->iman & IMAN_IE &&
> - xhci->usbcmd && USBCMD_INTE) {
> + xhci->usbcmd & USBCMD_INTE) {
> level = 1;
> }
>
--
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 16746 AG Nürnberg
next prev parent reply other threads:[~2012-04-02 9:50 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-04-02 6:35 [Qemu-devel] [PATCH] use: fix bit test Lai Jiangshan
2012-04-02 9:50 ` Andreas Färber [this message]
2012-04-03 2:52 ` Lai Jiangshan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4F797660.4070907@suse.de \
--to=afaerber@suse.de \
--cc=kraxel@redhat.com \
--cc=laijs@cn.fujitsu.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).