From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([208.118.235.92]:43255)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <pbonzini@redhat.com>) id 1SEfRm-0005V0-IV
	for qemu-devel@nongnu.org; Mon, 02 Apr 2012 07:29:24 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <pbonzini@redhat.com>) id 1SEfRg-0003Uj-DH
	for qemu-devel@nongnu.org; Mon, 02 Apr 2012 07:29:18 -0400
Received: from mx1.redhat.com ([209.132.183.28]:63337)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <pbonzini@redhat.com>) id 1SEfRg-0003Ue-5G
	for qemu-devel@nongnu.org; Mon, 02 Apr 2012 07:29:12 -0400
Message-ID: <4F798D75.8050009@redhat.com>
Date: Mon, 02 Apr 2012 13:28:53 +0200
From: Paolo Bonzini <pbonzini@redhat.com>
MIME-Version: 1.0
References: <1332417072-20329-1-git-send-email-pbonzini@redhat.com>
	<1332417072-20329-9-git-send-email-pbonzini@redhat.com>
	<CABoDooPTJVfrUG_F31SrSGPp4gS5odzAnUzKQfXH9fqsHTAcRA@mail.gmail.com>
In-Reply-To: <CABoDooPTJVfrUG_F31SrSGPp4gS5odzAnUzKQfXH9fqsHTAcRA@mail.gmail.com>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH 08/10] qapi: add strict mode to input
	visitor
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Laurent Desnogues <laurent.desnogues@gmail.com>
Cc: anthony@codemonkey.vs, lcapitulino@redhat.com, eblake@redhat.com, qemu-devel@nongnu.org, mdroth@linux.vnet.ibm.com

Il 02/04/2012 12:34, Laurent Desnogues ha scritto:
>> >  static void qmp_input_pop(QmpInputVisitor *qiv, Error **errp)
>> >  {
>> > +    GHashTableIter iter;
> GHashTableIter is alas not available in the glib (2.12) that
> the distros we use at work run.  Is there a workaround for
> this issue?

Yeah, since the hash table is going to be destroyed anyway, and will
always be empty in the common case, you can call
g_hash_table_foreach_remove, and raise an error if it returns > 0

Something like

gboolean hash_table_empty_check(gpointer key, gpointer value,
                                gpointer user_data)
{
    gpointer *p_key = user_data;
    if (!*p_key) {
        *p_key = key;
    }
    return true;
}

....

    key = NULL;
    if (g_hash_table_foreach_remove(qiv->stack[qiv->nb_stack - 1].h,
                                    hash_table_empty_check, &key) {
        error_set(errp, QERR_QMP_EXTRA_MEMBER, (char *) key);
    }
    g_hash_table_unref(qiv->stack[qiv->nb_stack - 1].h);

Can you make a patch?

Paolo