From: Stefan Weil <sw@weilnetz.de>
To: "Daniel P. Berrange" <berrange@redhat.com>
Cc: qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH 2/9] Fix checking for compiler flag support
Date: Mon, 02 Apr 2012 18:28:57 +0200 [thread overview]
Message-ID: <4F79D3C9.80205@weilnetz.de> (raw)
In-Reply-To: <1333363816-1691-3-git-send-email-berrange@redhat.com>
Am 02.04.2012 12:50, schrieb Daniel P. Berrange:
> From: "Daniel P. Berrange" <berrange@redhat.com>
>
> Some warning flags have dependancies, eg -Wformat-security cannot
> be enabled if -Wformat is not already enabled. The compiler
> flag checking code was checking each flag in isolation so several
> were not getting enabled. The fix is to supply all previously
> confirmed flags when checking a flag
>
> Signed-off-by: Daniel P. Berrange <berrange@redhat.com>
> ---
> configure | 6 ++++--
> 1 files changed, 4 insertions(+), 2 deletions(-)
>
This patch is not needed, because the current test adds
the supported flags to QEMU_CFLAGS which is used in compile_prog,
so it does exactly the same thing which you try to achieve.
For flags which have dependencies, the order is important, so
a comment for such cases would be good to avoid accidental
reordering (see your previous patch 1/9).
Regards,
Stefan W.
next prev parent reply other threads:[~2012-04-02 16:29 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-04-02 10:50 [Qemu-devel] Fix enablement of some compiler warning flags & add some more Daniel P. Berrange
2012-04-02 10:50 ` [Qemu-devel] [PATCH 1/9] Move all compiler warning/optimization flags to the same place Daniel P. Berrange
2012-04-02 16:19 ` Stefan Weil
2012-04-02 10:50 ` [Qemu-devel] [PATCH 2/9] Fix checking for compiler flag support Daniel P. Berrange
2012-04-02 12:29 ` Peter Maydell
2012-04-02 16:28 ` Stefan Weil [this message]
2012-04-02 10:50 ` [Qemu-devel] [PATCH 3/9] Print out progress when checking compiler flags Daniel P. Berrange
2012-04-02 13:56 ` Peter Maydell
2012-04-02 14:00 ` Daniel P. Berrange
2012-04-02 16:31 ` Stefan Weil
2012-04-02 10:50 ` [Qemu-devel] [PATCH 4/9] Remove 4 MB stack frame usage from sheepdog Daniel P. Berrange
2012-04-02 10:50 ` [Qemu-devel] [PATCH 5/9] Add in a large number of extra GCC warnings Daniel P. Berrange
2012-04-02 10:50 ` [Qemu-devel] [PATCH 6/9] Fix bit test to use & instead of && and enable -Wlogical-op warning Daniel P. Berrange
2012-04-02 12:27 ` Peter Maydell
2012-04-02 16:02 ` Maksim Kozlov
2012-04-02 10:50 ` [Qemu-devel] [PATCH 7/9] Add -Wmissing-format-attribute & fix problems it finds Daniel P. Berrange
2012-04-02 12:49 ` Andreas Färber
2012-04-02 10:50 ` [Qemu-devel] [PATCH 8/9] Add more format string warning flags Daniel P. Berrange
2012-04-02 12:13 ` Peter Maydell
2012-04-02 12:17 ` Daniel P. Berrange
2012-04-02 14:04 ` Peter Maydell
2012-04-02 14:22 ` Daniel P. Berrange
2012-04-02 14:32 ` Peter Maydell
2012-04-02 14:34 ` Daniel P. Berrange
2012-04-02 10:50 ` [Qemu-devel] [PATCH 9/9] Add note about some other options potentially worth enabling Daniel P. Berrange
2012-04-02 16:48 ` Stefan Weil
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4F79D3C9.80205@weilnetz.de \
--to=sw@weilnetz.de \
--cc=berrange@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).