From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([208.118.235.92]:48952)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <sw@weilnetz.de>) id 1SEk7q-0003iV-NQ
	for qemu-devel@nongnu.org; Mon, 02 Apr 2012 12:29:06 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <sw@weilnetz.de>) id 1SEk7o-0007HY-TW
	for qemu-devel@nongnu.org; Mon, 02 Apr 2012 12:29:02 -0400
Received: from v220110690675601.yourvserver.net ([78.47.199.172]:50415)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <sw@weilnetz.de>) id 1SEk7o-0007HK-OR
	for qemu-devel@nongnu.org; Mon, 02 Apr 2012 12:29:00 -0400
Message-ID: <4F79D3C9.80205@weilnetz.de>
Date: Mon, 02 Apr 2012 18:28:57 +0200
From: Stefan Weil <sw@weilnetz.de>
MIME-Version: 1.0
References: <1333363816-1691-1-git-send-email-berrange@redhat.com>
	<1333363816-1691-3-git-send-email-berrange@redhat.com>
In-Reply-To: <1333363816-1691-3-git-send-email-berrange@redhat.com>
Content-Type: text/plain; charset=ISO-8859-15; format=flowed
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH 2/9] Fix checking for compiler flag support
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: "Daniel P. Berrange" <berrange@redhat.com>
Cc: qemu-devel@nongnu.org

Am 02.04.2012 12:50, schrieb Daniel P. Berrange:
> From: "Daniel P. Berrange" <berrange@redhat.com>
>
> Some warning flags have dependancies, eg -Wformat-security cannot
> be enabled if -Wformat is not already enabled. The compiler
> flag checking code was checking each flag in isolation so several
> were not getting enabled. The fix is to supply all previously
> confirmed flags when checking a flag
>
> Signed-off-by: Daniel P. Berrange <berrange@redhat.com>
> ---
> configure | 6 ++++--
> 1 files changed, 4 insertions(+), 2 deletions(-)
>

This patch is not needed, because the current test adds
the supported flags to QEMU_CFLAGS which is used in compile_prog,
so it does exactly the same thing which you try to achieve.

For flags which have dependencies, the order is important, so
a comment for such cases would be good to avoid accidental
reordering (see your previous patch 1/9).

Regards,
Stefan W.