From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([208.118.235.92]:49644)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <sw@weilnetz.de>) id 1SEkAn-0005M9-Qo
	for qemu-devel@nongnu.org; Mon, 02 Apr 2012 12:32:14 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <sw@weilnetz.de>) id 1SEkAj-000862-2t
	for qemu-devel@nongnu.org; Mon, 02 Apr 2012 12:32:05 -0400
Received: from v220110690675601.yourvserver.net ([78.47.199.172]:51537)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <sw@weilnetz.de>) id 1SEkAi-00085s-TM
	for qemu-devel@nongnu.org; Mon, 02 Apr 2012 12:32:01 -0400
Message-ID: <4F79D47E.4010303@weilnetz.de>
Date: Mon, 02 Apr 2012 18:31:58 +0200
From: Stefan Weil <sw@weilnetz.de>
MIME-Version: 1.0
References: <1333363816-1691-1-git-send-email-berrange@redhat.com>
	<1333363816-1691-4-git-send-email-berrange@redhat.com>
In-Reply-To: <1333363816-1691-4-git-send-email-berrange@redhat.com>
Content-Type: text/plain; charset=ISO-8859-15; format=flowed
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH 3/9] Print out progress when checking
 compiler flags
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: "Daniel P. Berrange" <berrange@redhat.com>
Cc: qemu-devel@nongnu.org

Am 02.04.2012 12:50, schrieb Daniel P. Berrange:
> From: "Daniel P. Berrange"<berrange@redhat.com>
>
> Normal practice for autoconf style scripts is to print out
> progress. The QEMU configure script is getting increasingly
> slow&  has no progress feedback. Print out the progress of
> checking each compiler flag
>
> Signed-off-by: Daniel P. Berrange<berrange@redhat.com>
> ---
>   configure |    4 ++++
>   1 files changed, 4 insertions(+), 0 deletions(-)
>
> diff --git a/configure b/configure
> index 64ab4dc..44b28c8 100755
> --- a/configure
> +++ b/configure
> @@ -1170,8 +1170,12 @@ int main(void) { return 0; }
>   EOF
>   warning_flags=
>   for flag in $gcc_flags; do
> +    echo -n "checking if $cc supports $flag... "
>       if compile_prog "-Werror $warning_flags $flag" "" ; then
>   	warning_flags="$warning_flags $flag"
> +	echo "yes"
> +    else
> +	echo "no"
>       fi
>   done
>   QEMU_CFLAGS="$QEMU_CFLAGS $warning_flags"

This is not needed if we check all flags in a single step
(see my comment to patch 1/9).

IMHO, configure should not print progress feedback by default.