qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Anthony Liguori <anthony@codemonkey.ws>
To: Jan Kiszka <jan.kiszka@web.de>
Cc: Anthony Liguori <aliguori@us.ibm.com>,
	qemu-devel <qemu-devel@nongnu.org>
Subject: Re: [Qemu-devel] qdev property listing broken
Date: Mon, 02 Apr 2012 14:41:57 -0500	[thread overview]
Message-ID: <4F7A0105.8030707@codemonkey.ws> (raw)
In-Reply-To: <4F79FF0E.9090701@web.de>

On 04/02/2012 02:33 PM, Jan Kiszka wrote:
> Hi Anthony,
>
> I noticed that only properties with legacy names are printed via info
> qtree.

Yes.  Is that not what you expect?

The qom properties and model is not stable for 1.1 so I was very careful in 
making sure they didn't leak into info qtree.

> After digging through the qdev and qom property maze, it turned
> out the property registration in qdev_property_add_legacy and
> qdev_property_add_static is not consistent with the access in
> qdev_print_props.

qdev_print_props will completely die for 1.2 as will almost everything related 
to the human monitor in qdev-monitor.c.

I just wanted to give us a full release to make sure we were happy with the 
various interfaces.

> The latter assumes all properties are strings, the
> former generate the full set of types - and add_legacy obviously an
> inconsistent one, dependent on the existence of print/parse handlers. I
> fail to see the right direction, ie. where to fix this. Can you provide
> a hint?

Is there a reason you're using info qtree instead of qom-list?  qom-list gives 
you much more info than info qtree.

Regards,

Anthony Liguori


> Jan
>
> PS: It's really no fun to understand and debug this code anymore.
> Hopefully, the removal of the qdev layer can improve this again.

  parent reply	other threads:[~2012-04-02 19:42 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-04-02 19:33 [Qemu-devel] qdev property listing broken Jan Kiszka
2012-04-02 19:40 ` Paolo Bonzini
2012-04-02 19:43   ` Anthony Liguori
2012-04-02 20:07   ` Peter Maydell
2012-04-02 22:03     ` Paolo Bonzini
2012-04-02 22:27       ` Peter Maydell
2012-04-03  7:12         ` Paolo Bonzini
2012-04-02 23:38   ` Jan Kiszka
2012-04-02 19:41 ` Anthony Liguori [this message]
2012-04-02 19:44   ` Jan Kiszka
2012-04-02 19:48     ` Anthony Liguori
2012-04-02 19:50       ` Jan Kiszka
2012-04-02 20:07   ` Jan Kiszka
2012-04-02 20:10     ` Anthony Liguori

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4F7A0105.8030707@codemonkey.ws \
    --to=anthony@codemonkey.ws \
    --cc=aliguori@us.ibm.com \
    --cc=jan.kiszka@web.de \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).