From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:51004) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SEnEl-0007gH-CG for qemu-devel@nongnu.org; Mon, 02 Apr 2012 15:48:24 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1SEnEj-0007qd-H7 for qemu-devel@nongnu.org; Mon, 02 Apr 2012 15:48:22 -0400 Received: from mail-ob0-f173.google.com ([209.85.214.173]:33430) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SEnEj-0007qT-C4 for qemu-devel@nongnu.org; Mon, 02 Apr 2012 15:48:21 -0400 Received: by obbwd20 with SMTP id wd20so4922786obb.4 for ; Mon, 02 Apr 2012 12:48:19 -0700 (PDT) Message-ID: <4F7A0280.6030700@codemonkey.ws> Date: Mon, 02 Apr 2012 14:48:16 -0500 From: Anthony Liguori MIME-Version: 1.0 References: <4F79FF0E.9090701@web.de> <4F7A0105.8030707@codemonkey.ws> <4F7A018D.6040107@web.de> In-Reply-To: <4F7A018D.6040107@web.de> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] qdev property listing broken List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Jan Kiszka Cc: Anthony Liguori , qemu-devel On 04/02/2012 02:44 PM, Jan Kiszka wrote: > On 2012-04-02 21:41, Anthony Liguori wrote: >> On 04/02/2012 02:33 PM, Jan Kiszka wrote: >>> Hi Anthony, >>> >>> I noticed that only properties with legacy names are printed via info >>> qtree. >> >> Yes. Is that not what you expect? >> >> The qom properties and model is not stable for 1.1 so I was very careful >> in making sure they didn't leak into info qtree. >> >>> After digging through the qdev and qom property maze, it turned >>> out the property registration in qdev_property_add_legacy and >>> qdev_property_add_static is not consistent with the access in >>> qdev_print_props. >> >> qdev_print_props will completely die for 1.2 as will almost everything >> related to the human monitor in qdev-monitor.c. >> >> I just wanted to give us a full release to make sure we were happy with >> the various interfaces. > > This is broken as previously listed qdev properties disappeared. Yes, I misunderstood "legacy" names to include static properties too. You meant non-legacy static properties are broken. Pure qom properties are not displayed and never were displayed. Regards, Anthony Liguori > >> >>> The latter assumes all properties are strings, the >>> former generate the full set of types - and add_legacy obviously an >>> inconsistent one, dependent on the existence of print/parse handlers. I >>> fail to see the right direction, ie. where to fix this. Can you provide >>> a hint? >> >> Is there a reason you're using info qtree instead of qom-list? qom-list >> gives you much more info than info qtree. > > I'm using the monitor. > > Jan