From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:58448) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SEmkb-0000yC-1p for qemu-devel@nongnu.org; Mon, 02 Apr 2012 15:17:14 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1SEmkZ-0008T2-G9 for qemu-devel@nongnu.org; Mon, 02 Apr 2012 15:17:12 -0400 Received: from mail-bk0-f45.google.com ([209.85.214.45]:32775) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SEmkZ-0008Sk-6N for qemu-devel@nongnu.org; Mon, 02 Apr 2012 15:17:11 -0400 Received: by bkcjg9 with SMTP id jg9so3093233bkc.4 for ; Mon, 02 Apr 2012 12:17:08 -0700 (PDT) Message-ID: <4F7A094B.5010904@gmail.com> Date: Mon, 02 Apr 2012 23:17:15 +0300 From: Igor Mitsyanko MIME-Version: 1.0 References: <1333376921-13834-1-git-send-email-i.mitsyanko@samsung.com> <1333376921-13834-2-git-send-email-i.mitsyanko@samsung.com> In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 1/6] hw/sd.c: convert wp_groups in SDState to bitfield Reply-To: i.mitsyanko@samsung.com List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Peter Maydell Cc: balrog@zabor.org, quintela@redhat.com, michael@walle.cc, qemu-devel@nongnu.org, kyungmin.park@samsung.com, paul@codesourcery.com, afaerber@suse.de, d.solodkiy@samsung.com On 02.04.2012 5:42 PM, Peter Maydell wrote: > On 2 April 2012 15:28, Igor Mitsyanko wrote: >> Representing each group write protection flag with only one bit instead of int >> variable significantly reduces memory consumption. > > Can we use the bitmap.h functions here rather than doing things > by hand? (scattered examples below, you get the idea) > That's pretty cool, I didn't know about this, thanks.